Closed Bug 1576202 Opened 5 years ago Closed 5 years ago

Page load performance regressions with baseline interpreter enabled on Pixel 2

Categories

(Core :: JavaScript Engine: JIT, defect)

ARM64
Android
defect
Not set
normal

Tracking

()

RESOLVED INVALID
Performance Impact high

People

(Reporter: denispal, Unassigned)

References

Details

(Keywords: perf:pageload)

Attachments

(1 file)

Attached file baseline-interpreter-regressions.txt (deleted) —

I'm seeing a few regressions with baseline interpreter enabled for an ARM64 geckoview_example on the Pixel 2. I've attached the websites which are part of the tp6m p1 list. Unfortunately, I probably won't be able to provide much more information other than a gecko profile until I finish bug 1565788. I have not tried ARM32 yet.

Jan, would be able to look into this?

Flags: needinfo?(jdemooij)

Denis, can you say more about how you measured this exactly?

Flags: needinfo?(jdemooij) → needinfo?(dpalmeiro)

We talked about this a bit on IRC. javascript.options.blinterp = false will disable all JITs now so this could be an Ion compile time issue or something...

I'm also working on some low-level interpreter loop optimizations for ARM64 in bug 1576567.

(In reply to Jan de Mooij [:jandem] from comment #3)

We talked about this a bit on IRC. javascript.options.blinterp = false will disable all JITs now so this could be an Ion compile time issue or something...

I'm also working on some low-level interpreter loop optimizations for ARM64 in bug 1576567.

Thanks for the clarification. Doing a more extensive run, it does indeed seem like these regressions are actually caused by a mix of baselinejit and Ion. I will open new bugs specific to those and close this one.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(dpalmeiro)
Resolution: --- → INVALID

(In reply to Denis Palmeiro [:denispal] from comment #4)

Doing a more extensive run, it does indeed seem like these regressions are actually caused by a mix of baselinejit and Ion. I will open new bugs specific to those and close this one.

That's a relief :) Thanks for the update! For what it's worth, bug 1576567 just landed and it seems to be a small perf improvement when running the Baseline Interpreter on ARM64.

Performance Impact: --- → P1
Keywords: perf:pageload
Whiteboard: [qf:p1:pageload]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: