Affected versions

• Nightly 70.0a1

Affected platforms

• All Windows
• All Mac
• All Linux

Steps to reproduce

1. Launch latest Nightly browser.
2. Navigate to about:logins page.
3. Right click on 'frequently asked questions' link and select 'Open Link in New Tab' option from the contextual menu.

Expected result

• Frequently asked questions page is correctly opened in a new tab.

Actual result

• 'about:logins#' page is opened in a new tab.

Additional notes

• The issue is also reproducible if the middle click is used in order to open the link in a new tab.
• The problem is not encountered if the link is opened in the current page.

Since these links always open in a new tab maybe we should immediately open the tab on all clicks (right and middle on top of the existing left)? Switching to <a href=""> will fix this and it would mean we will also show the correct status bar text as well.

Jared, do you think this is P2 or P3? I'm leaning towards P2.

I'd prefer that we switch this to a regular link with target="_blank" rel="noreferrer", then we can allow the context menu to work as normal for other uses such as Open In New Window or Copy Link.

This also fixes a typo in the breach-alert-link to correctly use noreferrer.

Jared says that this patch causes a race with L10nOverlays. I'll take a look at this today.

Ok, that was fortunately easy to figure out!

What happens here is that your code caches the reference to the helpLink as this._helpLink and then attempts to set its attribute at a different time.
In between those two moments, a localization may happen, and it will recreate the element making your reference obsolete.

The papercut comes from the current limitation of L10nOverlays - it doesn't retain the identity of its child elements. I suggested a new revision of the API back in January that is designed to fix it [0].

To fix it, remove the cache this._helpLink and just querySelector in supportURL setter.
I'm sorry for the papercut, I hope we'll fix it soon!

[0] https://github.com/zbraniecki/fluent-domoverlays-js/wiki/New-Features-(rev-3)#7-retain-the-identity-of-source-elements

Documented in https://github.com/projectfluent/fluent.js/issues/169#issuecomment-528119993

Ah thanks, I had dealt with this before but didn't notice it happening again.

https://hg.mozilla.org/mozilla-central/rev/abf2b26f174a

I have verified this issue and is no longer reproducible on the latest Nightly 71.0a1 (2019-09-08) build on Windows 7 x64, Mac 10.14 and Ubuntu 16.04 x64.

• The "Firefox Lockwsie Support" page is correctly opened in a new tab.

Should we uplift this to beta70?

Yes, it needs uplift. I am working with David Durst and MattN to coordinate a single uplift of multiple patches to make sure they land in order and are merged properly.

https://hg.mozilla.org/releases/mozilla-beta/rev/6400129447ab

I have verified this issue and is no longer reproducible on the Firefox Beta 70.0b8 (Build ID: 20190919164641) build on Windows 7 x64, Mac 10.14 and Ubuntu 18.04 x64.

• The "Firefox Lockwsie Support" page is correctly opened in a new tab.