Closed Bug 1576707 Opened 5 years ago Closed 5 years ago

Allow "absolute" fetch artifacts to ignore `artifact_prefix`

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(10 files, 1 obsolete file)

(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details

The way that artifact-prefix works is that it applies to the consuming task's fetches... meaning that changing the prefix requires working out the new paths for every fetch in the consuming task. This ticket tracks allowing to "opt-out" of the artifact prefix mechanism for individual fetches.

aki: is my understanding above correct? Is this how artifact-prefix is intended to work? It would be much more useful if artifact-prefix meant things for producer tasks, and was gracefully interpolated into the consuming task fetches automatically. But that's not what we have, IIUC.

Flags: needinfo?(aki)

artifact-prefix could, and likely should, mean something for producer tasks, if and when we tie declarative artifacts in everywhere. (Right now declarative artifacts list things for consumer tasks to use, but aiui can't change the outputs of, say, a build task.)

I think your statement is accurate. If you're changing things for release tasks (e.g. shippable), you need to make sure your changes are reflected in declarative artifacts and matches artifact-prefix, or downstream release tasks will break. If this is just for testing, we don't have to worry about that.

Flags: needinfo?(aki)

The way that artifact-prefix works is that it applies to the
consuming task's fetches... meaning that changing the prefix
requires working out the new paths for every fetch in the consuming
task. This allows to "opt-out" of the artifact prefix mechanism for
individual fetches.

Depends on D43534

Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a7e698d5033 Allow "absolute" fetch artifacts to ignore `artifact_prefix`. r=aki
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b9dbcc4fdabf Allow "absolute" fetch artifacts to ignore `artifact_prefix`. r=aki
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Clearing NI since I relanded this.

Flags: needinfo?(nalexander)
Regressions: 1582399
No longer regressions: 1582399
Regressions: 1582399
Attachment #9102041 - Attachment description: Bug 1576707: [taskgraph] Get artifact prefix for fetches from dependent task. → Bug 1576707: [taskgraph] Get artifact prefix for fetches from dependent task; r?Callek
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/autoland/rev/422c28fdc436 [taskgraph] Move setting the task label eariler in the job transform; r=Callek https://hg.mozilla.org/integration/autoland/rev/51ea1470a436 [taskgraph] Add a better error message when trying to get artifact prefix; r=Callek https://hg.mozilla.org/integration/autoland/rev/282e733216aa [taskgraph] Allow fetching from fetch aliases as well; r=Callek https://hg.mozilla.org/integration/autoland/rev/ce148e5333aa [taskgraph] Get artifact prefix for fetches from dependent task; r=Callek
Flags: needinfo?(mozilla)

Fixing the typo, we see this in TB:
Exception: addon-calendar-l10n can't fetch toolchain-linux64-libdmg artifacts because there are no tasks with label toolchain-linux64-libdmg in kind dependencies!

That's more helpful.

Attachment #9103217 - Attachment description: Bug 1576707 - Follow-up: Fix typo in use_fetches. r=tomprince → Bug 1576707 - Follow-up: Fix typo in use_fetches. r=Callek
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/integration/autoland/rev/6333ec1b48dd Follow-up: Fix typo in use_fetches. r=Callek
Flags: needinfo?(mozilla)
Attachment #9137700 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: