Allow "absolute" fetch artifacts to ignore `artifact_prefix`
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(firefox70 fixed)
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(10 files, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details |
The way that artifact-prefix
works is that it applies to the consuming task's fetches... meaning that changing the prefix requires working out the new paths for every fetch in the consuming task. This ticket tracks allowing to "opt-out" of the artifact prefix mechanism for individual fetches.
Assignee | ||
Comment 1•5 years ago
|
||
aki: is my understanding above correct? Is this how artifact-prefix
is intended to work? It would be much more useful if artifact-prefix
meant things for producer tasks, and was gracefully interpolated into the consuming task fetches automatically. But that's not what we have, IIUC.
Comment 2•5 years ago
|
||
artifact-prefix
could, and likely should, mean something for producer tasks, if and when we tie declarative artifacts in everywhere. (Right now declarative artifacts list things for consumer tasks to use, but aiui can't change the outputs of, say, a build task.)
I think your statement is accurate. If you're changing things for release tasks (e.g. shippable), you need to make sure your changes are reflected in declarative artifacts and matches artifact-prefix
, or downstream release tasks will break. If this is just for testing, we don't have to worry about that.
Assignee | ||
Comment 3•5 years ago
|
||
The way that artifact-prefix
works is that it applies to the
consuming task's fetches... meaning that changing the prefix
requires working out the new paths for every fetch in the consuming
task. This allows to "opt-out" of the artifact prefix mechanism for
individual fetches.
Depends on D43534
Assignee | ||
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Backed out changeset 4a7e698d5033 (bug 1576707) for linting failure on /job/init.py:242:33.
Backout: https://hg.mozilla.org/integration/autoland/rev/97d70de52aec45bde0ce4f3d7e6001c979730d63
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=4a7e698d5033d9703aa7e91d68ffe793d55a5a08&selectedJob=263737237
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263737237&repo=autoland&lineNumber=223
Comment 7•5 years ago
|
||
bugherder |
Comment 9•5 years ago
|
||
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
Comment 12•5 years ago
|
||
Updated•5 years ago
|
Comment 13•5 years ago
|
||
Comment 14•5 years ago
|
||
bugherder |
Comment 15•5 years ago
|
||
You landed a typo here:
https://hg.mozilla.org/mozilla-central/rev/ce148e5333aa6b7f5376c22c6d9727a4639b93fe#l5.93
if len(dep_dep_tasks) == 0
Comment 16•5 years ago
|
||
Fixing the typo, we see this in TB:
Exception: addon-calendar-l10n can't fetch toolchain-linux64-libdmg artifacts because there are no tasks with label toolchain-linux64-libdmg in kind dependencies!
That's more helpful.
Comment 17•5 years ago
|
||
Updated•5 years ago
|
Comment 18•5 years ago
|
||
Comment 19•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Backports https://phabricator.services.mozilla.com/D49775 to taskgraph
Depends on D69341
Backports https://phabricator.services.mozilla.com/D49776 to taskgraph
Depends on D69342
Backports https://phabricator.services.mozilla.com/D49777 to taskgraph
Depends on D69343
Backports https://phabricator.services.mozilla.com/D49699 to taskgraph
Depends on D69344
Backports https://phabricator.services.mozilla.com/D50043 to taskgraph
Depends on D69345
Updated•5 years ago
|
Description
•