Closed Bug 1576718 Opened 5 years ago Closed 5 years ago

Deploylib needs to be able to validate images from multiple taskclusters

Categories

(Taskcluster :: Services, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: brian, Unassigned)

References

Details

From https://mozilla.slack.com/archives/CKBFXRD1T/p1566582670024900

bstack 1:51 PM
@bpitts oh, now that I look at validate_digest_taskcluster, it looks like it gets called when the url starts with tools.taskcluster.net which won't be true after this migration
so that's a bug we should get fixed as well. not sure what the proper fix is, maybe an extra field in build where we can specify which type of verification to have?

bpitts 2:18 PM
will the verification work the same, but just be at a new domain?
i'm thinking we could change https://github.com/mozilla-services/cloudops-infra-deploylib/blob/master/deploylib/docker.py#L176 to match all tc domains (edited)
oh, artifact domain at https://github.com/mozilla-services/cloudops-infra-deploylib/blob/master/deploylib/docker.py#L158 will also vary won't it
still, maybe we just get away with a map of taskcluster domains to artifact domains, and trigger taskcluster digest validation when the build url starts with any of the taskcluster domain keys?

Brian, if I ever understood this, I've forgotten what it meant by now. Still a thing?

Flags: needinfo?(bpitts)

I started trying to explain this, then realized it might be an even clearer explanation if I just tried to fix it.

https://github.com/mozilla-services/cloudops-infra-deploylib/pull/95

Flags: needinfo?(bpitts)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.