Ensure Quantum Bar Contextual Tip looks correct in RTL builds
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
People
(Reporter: dao, Assigned: adw)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details |
Judging by just looking at the code, this is probably not RTL-friendly: https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/browser/themes/shared/urlbar-autocomplete.inc.css#67
You normally want to use padding-inline-end instead of padding-right.
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
The padding-right is the oversight afaict. This patch is based on D45125.
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 5•5 years ago
|
||
I'm not sure we're planning on running on 70 the experiment that would use this -- I don't think so -- but it would be nice to have the option, and it's a trivial patch, so I'll request. Bug 1576888 too.
|
|
Assignee | |
Comment 6•5 years ago
|
||
Comment on attachment 9091222 [details]
Bug 1576889 - Ensure Quantum Bar Contextual Tip looks correct in RTL builds.
Beta/Release Uplift Approval Request
- User impact if declined: We may want to run an experiment on 70 that would use this patch.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It's a trivial one-line CSS patch. This UI isn't even visible in Firefox by default. It would only be shown in an experiment.
- String changes made/needed: None
Comment on attachment 9091222 [details]
Bug 1576889 - Ensure Quantum Bar Contextual Tip looks correct in RTL builds.
CSS fix for RTL, fine for uplift for beta 7.
|
||
Comment 8•5 years ago
|
||
| uplift | ||
Description
•