Closed Bug 1576917 Opened 5 years ago Closed 5 years ago

Port PopupBlockingChild from a message manager actor to a JSWindowActor

Categories

(Firefox :: Security, task, P3)

task

Tracking

()

RESOLVED FIXED
Firefox 74
Fission Milestone M5
Tracking Status
firefox74 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file, 5 obsolete files)

Assignee: nobody → a.vamvounis
Mentor: gijskruitbosch+bugs, mconley, brennie
Status: NEW → ASSIGNED
Attached file Bug 1576917 changed this to a JSWindowActor (obsolete) (deleted) —
Attached file Bug 1576917 (obsolete) (deleted) —

various fixes

Depends on D46623

Attached file Bug 1576917 (obsolete) (deleted) —

Popup list displaying correctly

Depends on D52577

Attached file Bug 1576917 (obsolete) (deleted) —

Correct number of popups is listed in the notification, the drop down menu works, and the menu options in the drop down work

Depends on D52601

Attachment #9107967 - Attachment is obsolete: true
Attachment #9107932 - Attachment is obsolete: true
Attachment #9094240 - Attachment is obsolete: true
Attachment #9094240 - Attachment is obsolete: false
Attachment #9107932 - Attachment is obsolete: false
Attachment #9107967 - Attachment is obsolete: false
Attached file Bug 1576917 (obsolete) (deleted) —

Added undefined check to the child

Depends on D52716

It makes me do this

Depends on D53074

Attachment #9108176 - Attachment is obsolete: true
Attachment #9094240 - Attachment is obsolete: true
Attachment #9108830 - Attachment is obsolete: true
Attachment #9107967 - Attachment is obsolete: true
Attachment #9107932 - Attachment is obsolete: true

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → ?
Fission Milestone: ? → M5
Attachment #9094240 - Attachment is obsolete: false

Blocks Fission dogfooding (M5).

Priority: -- → P3
Attachment #9094240 - Attachment is obsolete: true
Attachment #9094240 - Attachment is obsolete: false
Attachment #9094240 - Attachment is obsolete: true

Hi Alex, were you still planning on working on this now that the semester is over?

Flags: needinfo?(a.vamvounis)

I didn't hear back from Alex here or over email, so I'm going to assume I can commandeer this bug / patch.

Flags: needinfo?(a.vamvounis)
Assignee: a.vamvounis → mconley
Mentor: brennie, gijskruitbosch+bugs, mconley
No longer blocks: 1574175
Attachment #9108831 - Attachment description: Bug 1576917 → Bug 1576917 - Port PopupBlocker to JSWindowActors to make it Fission-compatible. r?NeilDeakin
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/653a287e0b7a Port PopupBlocker to JSWindowActors to make it Fission-compatible. r=NeilDeakin
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: