Closed Bug 1576918 Opened 5 years ago Closed 5 years ago

[Fission][MSU Capstone] Make the page style actor use Fission for messaging

Categories

(Firefox :: Menus, task, P3)

Product:
Firefox
Component:
Menus
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 72
Project Flags:
Fission Milestone M5
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: barret, Assigned: jahnsjam, Mentored)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1576918 - Port PageStyle actor to JSWindowActors for Fission compatibility.
(deleted), text/x-phabricator-request
Details

This is the code that is responsible for determining which style sheets apply to web pages:
https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/browser/actors/PageStyleChild.jsm

Actor spec:
https://searchfox.org/mozilla-central/source/browser/components/BrowserGlue.jsm#317-329

It is important to note that the sub-frame walking will need to be moved into the parent process

Assignee: nobody → jahnsjam
Status: NEW → ASSIGNED
Component: Async Tooling → Menus
Product: Toolkit → Firefox
Priority: -- → P3
Attached file Bug 1576918 WIP (obsolete) (deleted) —
Attachment #9094746 - Attachment description: Bug 1576918 → Bug 1576918 - Make the page style actor use Fission for messaging
Attachment #9094633 - Attachment is obsolete: true
Attachment #9094746 - Attachment description: Bug 1576918 - Make the page style actor use Fission for messaging → Bug 1576918

ni'ing myself for commentary in the Phab revision.

Flags: needinfo?(mconley)
Attachment #9094746 - Attachment description: Bug 1576918 → Bug 1576918 - Port PageStyle actor, which handles alternative stylesheets, to JSWindowActors for Fission compatibility.
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/530bcc00246e Port PageStyle actor, which handles alternative stylesheets, to JSWindowActors for Fission compatibility. r=mconley,Gijs

Backed out for browser-chrome failures on browser_dismissFooter.js

backout: https://hg.mozilla.org/integration/autoland/rev/e3ce16ac9143028c9f8353bff57a63aebcd5d127

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=530bcc00246e68a35fe03c19269d4282b9a0e8af&searchStr=browser-chrome&group_state=expanded&selectedJob=272840997

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272840997&repo=autoland&lineNumber=2310

[task 2019-10-24T20:34:07.102Z] 20:34:07 INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_dismissFooter.js | New tab opened to https://example.com/android?utm_creative=Footer_Menu -
[task 2019-10-24T20:34:07.103Z] 20:34:07 INFO - Test on https://example.com/apple?utm_creative=Footer_Menu
[task 2019-10-24T20:34:07.103Z] 20:34:07 INFO - Console message: [JavaScript Error: "TypeError: browser is null" {file: "resource:///actors/PageStyleParent.jsm" line: 12}]
[task 2019-10-24T20:34:07.104Z] 20:34:07 INFO - Console message: [JavaScript Error: "NS_ERROR_UNEXPECTED: "]
[task 2019-10-24T20:34:07.104Z] 20:34:07 INFO - Console message: [JavaScript Error: "TypeError: browser is null" {file: "resource:///actors/PageStyleParent.jsm" line: 12}]
[task 2019-10-24T20:34:07.105Z] 20:34:07 INFO - Console message: [JavaScript Error: "NS_ERROR_UNEXPECTED: "]
[task 2019-10-24T20:34:07.105Z] 20:34:07 INFO - Buffered messages finished
[task 2019-10-24T20:34:07.105Z] 20:34:07 INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_dismissFooter.js | [JavaScript Error: "NS_ERROR_UNEXPECTED: "] -
[task 2019-10-24T20:34:07.106Z] 20:34:07 INFO - Stack trace:
[task 2019-10-24T20:34:07.106Z] 20:34:07 INFO - chrome://mochikit/content/browser-test.js:test_ok:1297
[task 2019-10-24T20:34:07.106Z] 20:34:07 INFO - chrome://mochitests/content/browser/browser/components/aboutlogins/tests/browser/head.js:onConsoleMessage:113
[task 2019-10-24T20:34:07.107Z] 20:34:07 INFO - resource://specialpowers/SpecialPowersChild.jsm:observe/<:137
[task 2019-10-24T20:34:07.107Z] 20:34:07 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-24T20:34:07.107Z] 20:34:07 INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_dismissFooter.js | [JavaScript Error: "NS_ERROR_UNEXPECTED: "] -
[task 2019-10-24T20:34:07.108Z] 20:34:07 INFO - Stack trace:
[task 2019-10-24T20:34:07.108Z] 20:34:07 INFO - chrome://mochikit/content/browser-test.js:test_ok:1297
[task 2019-10-24T20:34:07.108Z] 20:34:07 INFO - chrome://mochitests/content/browser/browser/components/aboutlogins/tests/browser/head.js:onConsoleMessage:113
[task 2019-10-24T20:34:07.109Z] 20:34:07 INFO - resource://specialpowers/SpecialPowersChild.jsm:observe/<:137
[task 2019-10-24T20:34:07.109Z] 20:34:07 INFO - GECKO(2019) | 1571949246545 FirefoxAccounts ERROR FxA rejecting with error NO_ACCOUNT, details: undefined
[task 2019-10-24T20:34:07.109Z] 20:34:07 INFO - GECKO(2019) | console.error:
[task 2019-10-24T20:34:07.109Z] 20:34:07 INFO - GECKO(2019) | Refreshing device list failed.
[task 2019-10-24T20:34:07.109Z] 20:34:07 INFO - GECKO(2019) | Message: Error: NO_ACCOUNT
[task 2019-10-24T20:34:07.109Z] 20:34:07 INFO - GECKO(2019) | Stack:
[task 2019-10-24T20:34:07.109Z] 20:34:07 INFO - GECKO(2019) | _error@resource://gre/modules/FxAccounts.jsm:1740:18
[task 2019-10-24T20:34:07.110Z] 20:34:07 INFO - GECKO(2019) | withVerifiedAccountState/<@resource://gre/modules/FxAccounts.jsm:808:20
[task 2019-10-24T20:34:07.110Z] 20:34:07 INFO - GECKO(2019) | asyncwithCurrentAccountState@resource://gre/modules/FxAccounts.jsm:796:22
[task 2019-10-24T20:34:07.111Z] 20:34:07 INFO - GECKO(2019) | withVerifiedAccountState@resource://gre/modules/FxAccounts.jsm:804:17
[task 2019-10-24T20:34:07.111Z] 20:34:07 INFO - GECKO(2019) | _fetchAndCacheDeviceList@resource://gre/modules/FxAccountsDevice.jsm:247:8
[task 2019-10-24T20:34:07.111Z] 20:34:07 INFO - GECKO(2019) | refreshDeviceList@resource://gre/modules/FxAccountsDevice.jsm:228:19
[task 2019-10-24T20:34:07.111Z] 20:34:07 INFO - GECKO(2019) | refreshFxaDevices@chrome://browser/content/browser-sync.js:247:31
[task 2019-10-24T20:34:07.111Z] 20:34:07 INFO - GECKO(2019) | updateAllUI@chrome://browser/content/browser-sync.js:234:10
[task 2019-10-24T20:34:07.111Z] 20:34:07 INFO - GECKO(2019) | observe@chrome://browser/content/browser-sync.js:210:14
[task 2019-10-24T20:34:07.111Z] 20:34:07 INFO - GECKO(2019) | test_open_links@chrome://mochitests/content/browser/browser/components/aboutlogins/tests/browser/browser_dismissFooter.js:77:18
[task 2019-10-24T20:34:07.112Z] 20:34:07 INFO - GECKO(2019) | AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1067:34
[task 2019-10-24T20:34:07.112Z] 20:34:07 INFO - GECKO(2019) | async*Tester_execTest@chrome://mochikit/content/browser-test.js:1102:11
[task 2019-10-24T20:34:07.113Z] 20:34:07 INFO - GECKO(2019) | nextTest/<@chrome://mochikit/content/browser-test.js:930:14
[task 2019-10-24T20:34:07.113Z] 20:34:07 INFO - GECKO(2019) | SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:805:67
[task 2019-10-24T20:34:07.113Z] 20:34:07 INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_dismissFooter.js | Footer is visible - true == true -

Flags: needinfo?(jahnsjam)
Attachment #9094746 - Attachment description: Bug 1576918 - Port PageStyle actor, which handles alternative stylesheets, to JSWindowActors for Fission compatibility. → Bug 1576918 - Port PageStyle actor to JSWindowActors for Fission compatibility.
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ecc9cefef68d Port PageStyle actor to JSWindowActors for Fission compatibility. r=mconley,Gijs

https://hg.mozilla.org/mozilla-central/rev/ecc9cefef68d

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Flags: needinfo?(jahnsjam)
Depends on: 1595124
No longer depends on: 1595124
Regressions: 1595124
Regressions: 1595370

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M5
Regressions: 1645789
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: