Closed
Bug 157692
Opened 22 years ago
Closed 20 years ago
Should replace <label>s with <label for="">s
Categories
(Bugzilla :: User Interface, defect)
Bugzilla
User Interface
Tracking
()
RESOLVED
FIXED
Bugzilla 2.20
People
(Reporter: jouni, Assigned: annevk)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
We should change the templates using containing <label> syntax
(<label><element>text</label>) to use the indirect idref syntax (<label
for="someid">text</label><input id="someid" ...>, since Windows IE's up to
version 5.5 do not implement the containing syntax version properly (the labels
are not clickable).
There aren't too many instances of this yet, so it should be an easy fix.
Comment 1•22 years ago
|
||
This occured actually only once.
Comment 2•22 years ago
|
||
Comment on attachment 92934 [details] [diff] [review]
Remove <label> in favour of <label for="">
There is a bug in this patch (extra </label>).
This is fixed in the attachment to bug 157573.
Attachment #92934 -
Attachment is obsolete: true
Attachment #92934 -
Flags: review-
Comment 3•22 years ago
|
||
The User Interface component now belongs to Gerv. Reassigning all UNCONFIRMED
and NEW (but not ASSIGNED) bugs currently owned by Myk (the previous component
owner) to Gerv.
Assignee: myk → gerv
Comment 4•22 years ago
|
||
Reassigning back to Myk. That stuff about Gerv taking over the User Interface
component turned out to be short-lived. Please pardon our confusion, and I'm
very sorry about the spam.
Assignee: gerv → myk
Updated•21 years ago
|
Target Milestone: --- → Bugzilla 2.22
Assignee | ||
Comment 5•20 years ago
|
||
If this is r=myk, could you check it in as well? Thanks.
Comment 6•20 years ago
|
||
Comment on attachment 172902 [details] [diff] [review]
patch #1
Looks good, works well. r=myk
Nit: this would've been a good time to remove the control from within the label
tag, simplifying layout by making it less hierarchical, but it's not a big
deal.
Attachment #172902 -
Flags: review?(myk) → review+
Comment 7•20 years ago
|
||
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v <--
edit.html.tmpl
new revision: 1.52; previous revision: 1.51
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Flags: approval+
Resolution: --- → FIXED
Updated•20 years ago
|
Target Milestone: Bugzilla 2.22 → Bugzilla 2.20
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•