Can we remove the mozGetAll and mozGetAllKeys functions on IDBIndex and IDBObjectStore?
Categories
(Core :: Storage: IndexedDB, task, P3)
Tracking
()
People
(Reporter: bzbarsky, Unassigned)
References
(Blocks 2 open bugs)
Details
(Keywords: site-compat)
I assume other browsers don't have them. Why do we have these bits?
Reporter | ||
Comment 1•5 years ago
|
||
Also, what about IDBObjectStore.mozGetAll?
Reporter | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Jan and Andrew
Could you give comments remove these two attributes?
If you decide to remove them, I think I or Simon can help to write a patch for it.
Thanks.
Comment 3•5 years ago
|
||
getAll and getAllKeys are now part of the official IDB spec, so they should be moved from the partial interface to the main one.
mozGetAll is still used internally:
https://searchfox.org/mozilla-central/rev/7088fc958db5935eba24b413b1f16d6ab7bd13ea/dom/push/PushDB.jsm#316
That needs to be fixed.
We probably need to add use counters for mozGetAll and mozGetAllKeys before removing it, and maybe just deprecate them for now.
Also see this comment:
https://searchfox.org/mozilla-central/rev/7088fc958db5935eba24b413b1f16d6ab7bd13ea/dom/webidl/IDBObjectStore.webidl#63
Comment 4•5 years ago
|
||
getAll and getAllKeys were added in IndexedDB v2:
https://www.w3.org/TR/2016/WD-IndexedDB-2-20160818/
Comment 5•5 years ago
|
||
I'm in agreement with Jan. We should try and remove the moz-specific prefixed versions, but we should avoid breaking existing consumers, so use-counters are appropriate. As an extension of what Jan says, since these were standardized, the relative harm in exposing the getters is low, but it's still a worthwhile endeavor for us to remove them.
Updated•5 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Description
•