Closed Bug 1577238 Opened 5 years ago Closed 5 years ago

Solve dynamic URLs for RS messages

Categories

(Firefox :: Messaging System, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 72
Iteration:
72.3 - Nov 18 - Dec 1
Tracking Status
firefox72 --- fixed

People

(Reporter: andreio, Assigned: andreio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

URLs such as release notes, sumo articles for specific feature etc. are dynamically generated

Services.urlFormatter.formatURLPref(
        "app.support.baseURL"
      )&<static_query_params>

Currently easy to add to local messages: evaluate the expression as part of the message.
Not supported for RS messages.

Priority: -- → P2
Blocks: 1582064
No longer blocks: 1561009
Priority: P2 → P1
Iteration: --- → 72.3 - Nov 18 - Dec 1
Assignee: nobody → andrei.br92

Do we have a good way to track what firefox versions support what capabilities, e.g., this formatURL or remote l10n? We would need to make sure to target messages to only show up in versions that support them; otherwise, it seems quite easy to accidentally deploy a message that is broken in older firefoxes.

Flags: needinfo?(andrei.br92)

We have the What's New Panel content guide that mentions dynamic URLs starting 72+.
It would be nice to enforce some of these checks similar to how the documentation for our targeting getters is enforced through unit tests.
I think this would be more complicated. The way I see it possible is by landing the RS dumps in m-c and using mochitests to evaluate the messages.
However the usecase for the WNPanel seems to have shifted

No river. Card content will become dated, and we do not want users to depend on WNP as the place they find things

So we might not have the same long term support constraints like for snippets. If this changes we could try enforcing with mochitests.

Flags: needinfo?(andrei.br92)
Pushed by aoprea@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/74d6833f6173 Solve dynamic URLs for RS messages r=k88hudson
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: