Remove cmd_checkLinks that is unused
Categories
(SeaMonkey :: Composer, enhancement)
Tracking
(seamonkey2.49esr wontfix, seamonkey2.63 wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)
People
(Reporter: m_kato, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.1)
Attachments
(3 files, 1 obsolete file)
|
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
https://searchfox.org/comm-central/search?q=cmd_checkLinks&path=
cmd_checkLinks seems not to use in Thunderbird and SeaMonkey. Although debugQAEditorOverlay.xul has menu for this command, this is debugging tools.
This is only user of nsIHTMLEditor.getLinkedObjects that is unused by Firefox. So I hope that cmd_checkLinks is removed since it is unused since I would like to remove nsIHTMLEditor.getLinkedObjects from Gecko.
|
Reporter | |
Comment 1•5 years ago
|
||
Ian, is cmd_checkLinks still needed? This seems to be used on debugQA extension only. Although this command uses nsIHTMLEditor.getLinkedObjects method, it isn't used in Firefox and I would like to remove this method from Gecko.
|
||
Comment 2•5 years ago
|
||
I think it can be removed. It is a debugging help for Composer but seems to do nothing.
As cmd_checkLinks also relies on URIChecker which was removed in Bug 1222829 (in Gecko 45 around 4 years ago and spotted by me a year later), I'm fairly sure that nsIHTMLEditor.getLinkedObjects method can be removed.
Patch for comm-central that doesn't remove l10n
Patch for SM 2.57, does have l10n string removal
[Approval Request Comment]
Regression caused by (bug #): 1222829
User impact if declined: None, doesn't work anyway
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: One string removal and one dtd file removal
Include l10n removals as requested
|
|
||
Comment 8•5 years ago
|
||
|
|
||
Comment 9•5 years ago
|
||
|
|
||
Comment 10•5 years ago
|
||
|
||
Comment 11•5 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/429123f68201
Remove cmd_checkLinks that is unused. r=frg DONTBUILD
|
|
||
Comment 12•5 years ago
|
||
Fixed. Pushed with DONT BUILD all suite code (composer).
https://hg.mozilla.org/releases/comm-esr60/rev/c773e2fef6cab3d26aaf46c31e6789cfd6f75a22
|
|
||
Comment 14•5 years ago
|
||
Description
•