[Card Grid] Remove ds-header if empty and margin tweaks
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | verified |
People
(Reporter: wolasi, Assigned: thecount)
References
Details
(Keywords: github-merged)
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
Please make the following changes
- Remove the following CSS rule…
.collapsible-section.ds-layout .section-top-bar {
margin-bottom: 0;
}
-
Do not render
<div class="ds-header"></div>if there is not content -
Remove margins on
.ds-card-grid
|
Assignee | |
Comment 1•5 years ago
|
||
This is probably pretty easy fix. Might be worth trying to get in today.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
|
||
Comment 3•5 years ago
|
||
|
||
Comment 4•5 years ago
|
||
As I was trying to verify this issue I noticed that the margin-bottom for the .section-top-bar from the collapsible-section now has a value of 13px.
@Scott Was this change intended?
The margin for the .ds-card-grid is properly removed and no longer displayed.
|
|
||
Comment 6•5 years ago
|
||
I have verified this issue on Latest Firefox Nightly 71.0a1 (Build ID: 20190902213933) on Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64.
The margin for the .ds-card-grid is properly removed and no longer displayed and considering the Comment 5
the margin-bottom for the .section-top-bar from the collapsible-section has a value of 13px as expected.
Description
•