The mouse isn't properly followed in the graphical part
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)
Tracking
(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox69 unaffected, firefox70 verified, firefox71+ verified)
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox69 | --- | unaffected |
firefox70 | --- | verified |
firefox71 | + | verified |
People
(Reporter: julienw, Assigned: jdescottes)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
STR:
- Record some profile from the performance tab in the devtools. Note: this is about the default (aka old) panel.
- Hover with the mouse on top of the graphical part at the top of the window.
=> see that the vertical cursor doesn't follow the mouse properly, there's some translation. - Try to select a range.
=> the translation is still there.
I found that the problem is even worse when the devtools are docked to the right, and not too wide.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 1•5 years ago
|
||
I reproduced on Mac and Linux.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Managed to reproduce the issue on Nightly 71.0a1 (2019-09-09) with MacOS 10.13.6.
- Regression results from mozregression:
- Last good revision: 91f7769b3d7ec17aa11f7a8ada7104f5b4cec38d
- First bad revision: 39e19afc797d310f568447eae7054789e641b591
- Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=91f7769b3d7ec17aa11f7a8ada7104f5b4cec38d&tochange=39e19afc797d310f568447eae7054789e641b591
Reporter | ||
Comment 3•5 years ago
|
||
Thanks Gabi!
Looks like bug 1539979 regressed this, then.
Julian, any idea?
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
thanks for the ping!
In Graphs.js (https://searchfox.org/mozilla-central/rev/588814f2edddf0e132d77d326ddae50911e8bad1/devtools/client/shared/widgets/Graphs.js#109), the following code no longer returns the expected window when running in a content frame.
this._topWindow = this._window.top;
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 7•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 8•5 years ago
|
||
Is this something we should consider for Beta uplift?
Assignee | ||
Comment 9•5 years ago
|
||
Comment on attachment 9091919 [details]
Bug 1578373 - Stop using window.top in devtools/client/shared/widgets/Graphs.js
Beta/Release Uplift Approval Request
- User impact if declined: UI Bug when using the performance panel in DevTools
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: (adapted from the summary)
- open devtools
- dock devtools to the right
- select performance panel
- record a profile
- mouseover the profile to see the vertical cursor appear in the chart
ER: the vertical line should be exactly under the cursor
AR: the vertical line is either invisible or has an offset
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Minor javascript change
- String changes made/needed:
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Verified as fixed with 71.0a1 (2019-09-22) on Windows 10x64, Ubuntu 16.04 and macOS 10.13.6
Updated•5 years ago
|
Updated•5 years ago
|
Comment 11•5 years ago
|
||
Comment on attachment 9091919 [details]
Bug 1578373 - Stop using window.top in devtools/client/shared/widgets/Graphs.js
Minimal js patch which fixes a regression and was verified on Nightly, uplift appoved for 70 beta 9, thanks.
Comment 12•5 years ago
|
||
bugherder uplift |
Assignee | ||
Updated•5 years ago
|
Comment 13•5 years ago
|
||
Verified as fixed with 70.0b9 on Ubuntu 18.04, Windows 10x64 and macOS 10.13.6.
Updated•5 years ago
|
Description
•