Closed Bug 1578407 Opened 5 years ago Closed 5 years ago

The "Get your passwords on your other devices" text exceed the header area on localized builds if the browser is horizontally resized

Categories

(Firefox :: about:logins, defect, P2)

70 Branch
Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- disabled
firefox70 --- verified
firefox71 --- verified

People

(Reporter: cmuntean, Assigned: mcrawford)

References

(Regressed 1 open bug)

Details

(Whiteboard: [passwords:management] [skyline])

Attachments

(2 files)

Attached image text exceed the header.png (deleted) —

[Affected Versions]:

  • Nightly 71.0a1
  • Beta 70.0b3

[Affected Platforms]

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]

  • Have a Firefox Beta 70.0b3 it build.
  • Have a Firefox profile where you are not logged into a FxA account.

[Steps to reproduce]:

  1. Open the Beta 70.0b3 Italian build with the profile from prerequisites.
  2. Navigate to "about:logins" page.
  3. Resize the browser horizontally.
  4. and observe the "Get your passwords on your other devices" text.

[Expected results]:

  • The text is correctly displayed and doesn't exceed the header area.

[Actual results]:

  • The text exceed the header area.

[Notes]:

  • Attached a screenshot with the issue.
Priority: -- → P2
Assignee: nobody → mcrawford
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aeb5ff5e6aa7 The "Get your passwords on your other devices" text exceed the header area on localized builds if the browser is horizontally resized r=jaws
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

I have tested this issue and is still reproducible on the latest Nightly It locale 71.0a1 (Build ID: 20190913092859) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 16.04 x64. The "Get your passwords on your other devices" text is still exceeding the header area.
Considering this, I will reopen this issue.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Can you please provide a screenshot?

Flags: needinfo?(simona.rosu)

Please don't reopen bugs unless the patch is backed out. Can you please file a new bug for the issue? I am able to confirm that at a window width of about 810px the text overflows the container. In this situation we agreed we should just hide the promotional text.

Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED

I understood, sorry for this inconvenience.
Considering the fact that the issue is still reproducible if the window is horizontally resized I have logged a new issue for this in bug 1581506

However, I have verified the changes made on the latest Nightly 71.0a1 (2019-09-15) build on Windows 10 x64, Mac 10.14 and Ubuntu 16.04 x64

  • In order to verify this, I have used the "Inspector" tool and the changes made are visible.
    Based on this, I will mark this issue as verified fixed and will track the issue described above in bug 1581506.
Status: RESOLVED → VERIFIED
Flags: needinfo?(simona.rosu)
Flags: qe-verify+

I have verified this issue on the Firefox Beta 70.0b8 (Build ID: 20190919164641) (64-bit) on Windows 7, MacOS 10.14 and Arch 4.14.

  • The changes are correctly visible using the inspector tool, also improvements can be observed while resizing the browser.
Flags: qe-verify+
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla71 → Firefox 71
Version: 71 Branch → 70 Branch
Regressions: 1635143
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: