Closed Bug 1578569 Opened 5 years ago Closed 5 years ago

Padding is wrong in bookmarks popup for some submenus

Categories

(Toolkit :: XUL Widgets, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla71
Tracking Status
firefox71 --- verified

People

(Reporter: bgrins, Assigned: bgrins)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

I re-added a CSS rule in Bug 1573158 to handle overflowing menus (https://hg.mozilla.org/integration/autoland/rev/3f54e52c52eb#l2.12) but now I notice that causes some vertical misalignment for some non-overflowing submenus.

Attached image last-item-clipped.png (deleted) —
Attached image padding-only-at-top.png (deleted) —

This was removed in Bug 1573158, where the following line change forced it to 0px:
https://hg.mozilla.org/integration/autoland/rev/3f54e52c52eb#l2.12

This uses shadow parts instead of Shadow DOM + XBL selectors into the arrowscrollbox,
which unblocks arrowscrollbox Custom Element conversion and appears to have the same
visual effect as far as I can tell.

Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b5a403990b1 Restore padding-bottom on certain menupopups inside BMB_bookmarksPopup r=mak
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Flags: qe-verify+

I did not manage to reproduce the issue using Fx 71.0a1 (2019-09-02). Can you verify that the issue is fixed? http://archive.mozilla.org/pub/devedition/candidates/71.0b11-candidates/build1/

Flags: needinfo?(bgrinstead)

(In reply to Negritas Sergiu from comment #6)

I did not manage to reproduce the issue using Fx 71.0a1 (2019-09-02). Can you verify that the issue is fixed? http://archive.mozilla.org/pub/devedition/candidates/71.0b11-candidates/build1/

Should be fixed in 71, yes. Marking as verified.

Status: RESOLVED → VERIFIED
Flags: needinfo?(bgrinstead)

Thank you for the response I will clear the remaining flags.

Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: