Closed Bug 1578583 Opened 5 years ago Closed 5 years ago

Add support for a resultSpan property on results

Categories

(Firefox :: Address Bar, enhancement, P2)

Product:
Firefox
Component:
Address Bar
Type:
enhancement
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 71
Iteration:
71.2 - Sept 16 - 29
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file)

Bug 1578583 - Add support for a resultSpan property on results. r?adw
(deleted), text/x-phabricator-request
Details

This property allows Urlbar results to span multiple rows in the autocomplete dropdown. It is needed so that Interventions can span three rows. We'd need something like UrlbarUtils.getResultSpanForType(result.type) to return resultSpan for a given type. We could implement this by setting a min-height on result rows and use resultSpan as a multiplier, or we could possibly make the results a flexbox and set the rows' flex-grow equal to resultSpan.

Assignee: nobody → htwyford
Iteration: --- → 71.2 - Sept 16 - 29
Status: NEW → ASSIGNED
Priority: -- → P2
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96fecf5a0833 Add support for a resultSpan property on results. r=adw

https://hg.mozilla.org/mozilla-central/rev/96fecf5a0833

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Regressions: 1582329
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: