Closed Bug 1578623 Opened 5 years ago Closed 5 years ago

Include stacks with console messages for uncaught exceptions in worklet scripts

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla71

Tracking Flags:

Tracking

Status

firefox71

---

fixed

People

(Reporter: karlt, Assigned: karlt)

References

(Blocks 1 open bug)

Details

Attachments

(13 files)

bug 1578623 store PrincipalInfo on WorkletImpl for off-main-thread use r?baku 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details
Bug 1578623 create worklet global with JSPrincipals having reference to WorkletImpl r?baku 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details
Bug 1578623 implement WorkletPrincipals::write() 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details
Bug 1578623 permit SerializeStack() from worklet thread r?baku 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details
Bug 1578623 remove documentation for non-existent parameter r?bholley 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details
Bug 1578623 add stack support to AsyncErrorReporter r?bholley 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details
Bug 1578623 include stack with console message for uncaught exception in worklet script r?baku 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details
Bug 1578623 use 1 for first line number of worklet scripts r?baku 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details
Bug 1578623 ignore self-hosted frames when testing console message stack line numbers r?bhackett 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details
Bug 1578623 add test for syntax errors and uncaught exceptions in worklet scripts r?bhackett 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details
Bug 1578623 move principal-related data from LoadInfo to WorkletImpl r?baku 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details
Bug 1578623 use an opaque origin for WorkletGlobalScope r?baku 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details
Bug 1578623 remove OriginAttributes duplication by reading from PrincipalInfo r?baku 5 years ago Karl Tomlinson (:karlt) (deleted), text/x-phabricator-request		Details

Karl Tomlinson (:karlt)

Assignee

Description

•

5 years ago

Script errors use nsIConsoleService with nsScriptErrorWithStack, which expects a JS stack object, which I assume is usually based on SavedFrame.
Console OTOH uses "console-api-log-event" with ConsoleStackEntry reification of stacks for logging.
WebConsoleActor.prepareStackForRemote() converts SavedFrame to what might be equivalent to ConsoleStackEntry, but is expecting nsIScriptError messages to have stacks in SavedFrame format.
SerializedStackHolder exists for passing SavedFrame stacks across threads.

Karl Tomlinson (:karlt)

Assignee

Comment 1

•

5 years ago

Attached file bug 1578623 store PrincipalInfo on WorkletImpl for off-main-thread use r?baku (deleted) — Details

Depends on D44602

Karl Tomlinson (:karlt)

Assignee

Comment 2

•

5 years ago

Attached file Bug 1578623 create worklet global with JSPrincipals having reference to WorkletImpl r?baku (deleted) — Details

This will permit implementation of JSPrincipals::write().

Depends on D44603

Karl Tomlinson (:karlt)

Assignee

Comment 3

•

5 years ago

Attached file Bug 1578623 implement WorkletPrincipals::write() (deleted) — Details

Depends on D44604

Karl Tomlinson (:karlt)

Assignee

Comment 4

•

5 years ago

Attached file Bug 1578623 permit SerializeStack() from worklet thread r?baku (deleted) — Details

Depends on D44605

Karl Tomlinson (:karlt)

Assignee

Comment 5

•

5 years ago

Attached file Bug 1578623 remove documentation for non-existent parameter r?bholley (deleted) — Details

This comment has been obsolete since
https://hg.mozilla.org/mozilla-central/rev/cf4859464f9ea5c3bb44e35d328c13d02114f13a#l2.31
where it was clarified at
https://hg.mozilla.org/mozilla-central/rev/cf4859464f9ea5c3bb44e35d328c13d02114f13a#l5.75

Depends on D44606

Karl Tomlinson (:karlt)

Assignee

Comment 6

•

5 years ago

Attached file Bug 1578623 add stack support to AsyncErrorReporter r?bholley (deleted) — Details

Depends on D44607

Karl Tomlinson (:karlt)

Assignee

Comment 7

•

5 years ago

Attached file Bug 1578623 include stack with console message for uncaught exception in worklet script r?baku (deleted) — Details

Depends on D44608

Karl Tomlinson (:karlt)

Assignee

Comment 8

•

5 years ago

Attached file Bug 1578623 use 1 for first line number of worklet scripts r?baku (deleted) — Details

This is consistent with what the Web Console expects.

Depends on D44609

Karl Tomlinson (:karlt)

Assignee

Comment 9

•

5 years ago

Attached file Bug 1578623 ignore self-hosted frames when testing console message stack line numbers r?bhackett (deleted) — Details

Line numbers in self-hosted frames are not controlled by the test.

Depends on D44610

Karl Tomlinson (:karlt)

Assignee

Comment 10

•

5 years ago

Attached file Bug 1578623 add test for syntax errors and uncaught exceptions in worklet scripts r?bhackett (deleted) — Details

Depends on D44611

Karl Tomlinson (:karlt)

Assignee

Updated

•

5 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1156467

Phabricator Automation

Updated

•

5 years ago

Attachment #9090281 - Attachment description: Bug 1578623 implement WorkletPrincipals::write() r?baku → Bug 1578623 implement WorkletPrincipals::write()

Karl Tomlinson (:karlt)

Assignee

Updated

•

5 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1578968

Karl Tomlinson (:karlt)

Assignee

Comment 11

•

5 years ago

Attached file Bug 1578623 move principal-related data from LoadInfo to WorkletImpl r?baku (deleted) — Details

The principals used in worklet scripts derive from the relevant settings object
of the main thread Worklet object, rather than the network loads of the scripts.
Moving the data off LoadInfo removes any implication that the principals might
depend on script module loads.

Karl Tomlinson (:karlt)

Assignee

Comment 12

•

5 years ago

Attached file Bug 1578623 use an opaque origin for WorkletGlobalScope r?baku (deleted) — Details

The environment settings object for a WorkletGlobalScope derives from the
relevant settings object of the main-thread Worklet object, but the origin is
a unique opaque origin.
https://drafts.css-houdini.org/worklets/#set-up-a-worklet-environment-settings-object

Depends on D44775

Phabricator Automation

Updated

•

5 years ago

Attachment #9090279 - Attachment description: Bug 1578623 store PrincipalInfo on WorkletLoadInfo for off-main-thread use r?baku → bug 1578623 store PrincipalInfo on WorkletImpl for off-main-thread use r?baku

Karl Tomlinson (:karlt)

Assignee

Comment 13

•

5 years ago

Attached file Bug 1578623 remove OriginAttributes duplication by reading from PrincipalInfo r?baku (deleted) — Details

Pulsebot

Comment 14

•

5 years ago

Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe16058974e0 create worklet global with JSPrincipals having reference to WorkletImpl r=baku,bzbarsky https://hg.mozilla.org/integration/autoland/rev/94f6ee4ceef0 remove documentation for non-existent parameter r=bholley https://hg.mozilla.org/integration/autoland/rev/e58800cb5882 use 1 for first line number of worklet scripts r=baku https://hg.mozilla.org/integration/autoland/rev/848723605c2c ignore self-hosted frames when testing console message stack line numbers r=bhackett

Karl Tomlinson (:karlt)

Assignee

Updated

•

5 years ago

Keywords: leave-open

Alexandru Michis [:malexandru]

Updated

•

5 years ago

Regressions: 1579325

Noemi Erli[:noemi_erli]

Comment 15

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/fe16058974e0
https://hg.mozilla.org/mozilla-central/rev/94f6ee4ceef0
https://hg.mozilla.org/mozilla-central/rev/e58800cb5882
https://hg.mozilla.org/mozilla-central/rev/848723605c2c

Pulsebot

Comment 16

•

5 years ago

Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3be609a9be36 move principal-related data from LoadInfo to WorkletImpl r=baku https://hg.mozilla.org/integration/autoland/rev/6d7be8a22f8b use an opaque origin for WorkletGlobalScope r=baku https://hg.mozilla.org/integration/autoland/rev/8242877392bd store PrincipalInfo on WorkletImpl for off-main-thread use r=baku https://hg.mozilla.org/integration/autoland/rev/0128e12a910f implement WorkletPrincipals::write() r=bzbarsky https://hg.mozilla.org/integration/autoland/rev/71e58ee8f684 permit SerializeStack() from worklet thread r=baku https://hg.mozilla.org/integration/autoland/rev/3badf9215788 add stack support to AsyncErrorReporter r=bholley https://hg.mozilla.org/integration/autoland/rev/65a7c4daec27 include stack with console message for uncaught exception in worklet script r=baku https://hg.mozilla.org/integration/autoland/rev/e4fddd3d24b4 add test for syntax errors and uncaught exceptions in worklet scripts r=bhackett https://hg.mozilla.org/integration/autoland/rev/52a86c60c866 remove OriginAttributes duplication by reading from PrincipalInfo r=baku

Karl Tomlinson (:karlt)

Assignee

Updated

•

5 years ago

Keywords: leave-open

Noemi Erli[:noemi_erli]

Comment 17

•

5 years ago

Backed out 9 changesets (Bug 1578623) for causing Windows build bustages CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=52a86c60c8664cb41fb20daf94c620264726b4d9&searchStr=windows

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265626215&repo=autoland&lineNumber=33955

Backout: 92823ffcb1dcdbd393ca322e52f604f2127ca3cd

Noemi Erli[:noemi_erli]

Updated

•

5 years ago

Flags: needinfo?(karlt)

Karl Tomlinson (:karlt)

Assignee

Updated

•

5 years ago

Depends on: 834505

Karl Tomlinson (:karlt)

Assignee

Updated

•

5 years ago

Flags: needinfo?(karlt)

Keywords: leave-open

Pulsebot

Comment 18

•

5 years ago

Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/11cda2e9615b move principal-related data from LoadInfo to WorkletImpl r=baku https://hg.mozilla.org/integration/autoland/rev/a83797ed249c use an opaque origin for WorkletGlobalScope r=baku

Natalia Csoregi [:nataliaCs]

Comment 19

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/11cda2e9615b
https://hg.mozilla.org/mozilla-central/rev/a83797ed249c

Karl Tomlinson (:karlt)

Assignee

Updated

•

5 years ago

Keywords: leave-open

Pulsebot

Comment 20

•

5 years ago

Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a67e6e7defba store PrincipalInfo on WorkletImpl for off-main-thread use r=baku https://hg.mozilla.org/integration/autoland/rev/99c181965128 implement WorkletPrincipals::write() r=bzbarsky https://hg.mozilla.org/integration/autoland/rev/1720f0a8952b permit SerializeStack() from worklet thread r=baku https://hg.mozilla.org/integration/autoland/rev/52c6a60efe7c add stack support to AsyncErrorReporter r=bholley https://hg.mozilla.org/integration/autoland/rev/ea60c5110b4a include stack with console message for uncaught exception in worklet script r=baku https://hg.mozilla.org/integration/autoland/rev/0665b9520daa add test for syntax errors and uncaught exceptions in worklet scripts r=bhackett https://hg.mozilla.org/integration/autoland/rev/37062227d710 remove OriginAttributes duplication by reading from PrincipalInfo r=baku

Noemi Erli[:noemi_erli]

Comment 21

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/a67e6e7defba
https://hg.mozilla.org/mozilla-central/rev/99c181965128
https://hg.mozilla.org/mozilla-central/rev/1720f0a8952b
https://hg.mozilla.org/mozilla-central/rev/52c6a60efe7c
https://hg.mozilla.org/mozilla-central/rev/ea60c5110b4a
https://hg.mozilla.org/mozilla-central/rev/0665b9520daa
https://hg.mozilla.org/mozilla-central/rev/37062227d710

Status: ASSIGNED → RESOLVED

Closed: 5 years ago

status-firefox71: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla71

Cristian Brindusan [:cbrindusan]

Updated

•

5 years ago

Regressions: 1582445

Karl Tomlinson (:karlt)

Assignee

Updated

•

5 years ago

Blocks: worklets-1

You need to log in before you can comment on or make changes to this bug.