Closed Bug 1578777 Opened 5 years ago Closed 5 years ago

Div is not scrollable with mouse(but possible with dragging the scrollbar) when WebRender is enabled

Tracking

()

Status:

VERIFIED FIXED

Milestone:

mozilla71

Tracking Flags:

Tracking

Status

firefox71

---

verified

People

(Reporter: canova, Assigned: botond)

References

(Regression)

Details

(Keywords: regression)

Attachments

(7 files)

Bug 1578777 - Remove non-ASCII character from comment in WebRenderCommandBuilder.cpp. r=jrmuizel 5 years ago Botond Ballo [:botond] (deleted), text/x-phabricator-request		Details
Bug 1578777 - Remove the builder parameter from nsDisplayFilters::CreateWebRenderCommands(). r=jrmuizel 5 years ago Botond Ballo [:botond] (deleted), text/x-phabricator-request		Details
Bug 1578777 - Move CreateWebRenderCSSFilters() to nsSVGIntegrationUtils. r=jrmuizel 5 years ago Botond Ballo [:botond] (deleted), text/x-phabricator-request		Details
Bug 1578777 - Introduce a helper nsSVGIntegrationUtils::CanCreateWebRenderFiltersForFrame(). r=jrmuizel 5 years ago Botond Ballo [:botond] (deleted), text/x-phabricator-request		Details
Bug 1578777 - Use CanCreateWebRenderFiltersForFrame() in ScrollFrameWillBuildScrollInfoLayer(). r=tnikkel 5 years ago Botond Ballo [:botond] (deleted), text/x-phabricator-request		Details
Bug 1578777 - Move UsesSVGEffectsNotSupportedInCompositor() to nsSVGIntegrationUtils. r=tnikkel 5 years ago Botond Ballo [:botond] (deleted), text/x-phabricator-request		Details
Bug 1578777 - Use UsesSVGEffectsNotSupportedInCompositor() in ShouldBuildScrollInfoItemsForHoisting(). r=tnikkel 5 years ago Botond Ballo [:botond] (deleted), text/x-phabricator-request		Details

Nazım Can Altınova [:canova][:canaltinova on phabricator]

Reporter

Description

•

5 years ago

I encountered this while I was looking on a profile in profiler.firefox.com.
STR:

Open https://perfht.ml/34mruX1 .
Make the window height narrower so we can see the scrollbar.
Click to the "Firefox (65.0) Intel Mac OS X 10.14" text on top right corner to open the metadata popup panel.
Try to scroll with your mouse without dragging the scrollbar

It works without webrender enabled and realized that it works with previous versions of webrender. Did a mozregression run and found out that this is regressed by https://hg.mozilla.org/integration/autoland/rev/c0a07a2c5d0263b35ceb271c668a41256b959630 (Bug 1550510).

Jessie [:jbonisteel] pls NI

Comment 1

•

5 years ago

I could reproduce this on my mac. Jeff, any suggestions?

Blocks: wr-70

Flags: needinfo?(jmuizelaar)

Priority: -- → P3

Jeff Muizelaar [:jrmuizel]

Comment 2

•

5 years ago

Let's ask Botond

Flags: needinfo?(jmuizelaar) → needinfo?(botond)

Botond Ballo [:botond]

Assignee

Comment 3

•

5 years ago

The scrollable element in question is not being layerized for some reason, even after user interaction.

Botond Ballo [:botond]

Assignee

Comment 4

•

5 years ago

It's not being layerized because it's inside a filter that WebRender doesn't support.

Bug 1550510 assumed that with WR we can handle all filters in the compositor and therefore we can layerize all scrollable elements inside filters. That's not the case.

Flags: needinfo?(botond)

Botond Ballo [:botond]

Assignee

Updated

•

5 years ago

Assignee: nobody → botond

Botond Ballo [:botond]

Assignee

Comment 5

•

5 years ago

Attached file Bug 1578777 - Remove non-ASCII character from comment in WebRenderCommandBuilder.cpp. r=jrmuizel (deleted) — Details

Botond Ballo [:botond]

Assignee

Comment 6

•

5 years ago

Attached file Bug 1578777 - Remove the builder parameter from nsDisplayFilters::CreateWebRenderCommands(). r=jrmuizel (deleted) — Details

It was unused.

Depends on D46057

Botond Ballo [:botond]

Assignee

Comment 7

•

5 years ago

Attached file Bug 1578777 - Move CreateWebRenderCSSFilters() to nsSVGIntegrationUtils. r=jrmuizel (deleted) — Details

Depends on D46058

Botond Ballo [:botond]

Assignee

Comment 8

•

5 years ago

Attached file Bug 1578777 - Introduce a helper nsSVGIntegrationUtils::CanCreateWebRenderFiltersForFrame(). r=jrmuizel (deleted) — Details

Depends on D46059

Botond Ballo [:botond]

Assignee

Comment 9

•

5 years ago

Attached file Bug 1578777 - Use CanCreateWebRenderFiltersForFrame() in ScrollFrameWillBuildScrollInfoLayer(). r=tnikkel (deleted) — Details

Depends on D46060

Botond Ballo [:botond]

Assignee

Comment 10

•

5 years ago

Attached file Bug 1578777 - Move UsesSVGEffectsNotSupportedInCompositor() to nsSVGIntegrationUtils. r=tnikkel (deleted) — Details

Depends on D46061

Botond Ballo [:botond]

Assignee

Comment 11

•

5 years ago

Attached file Bug 1578777 - Use UsesSVGEffectsNotSupportedInCompositor() in ShouldBuildScrollInfoItemsForHoisting(). r=tnikkel (deleted) — Details

This required replacing nsDisplayListBuilder::mSVGEffectsBuildingDepth with
a stack of the SVG effects frames that we're currently building inside.

Depends on D46063

Pulsebot

Comment 12

•

5 years ago

Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff6a071cf39e Remove non-ASCII character from comment in WebRenderCommandBuilder.cpp. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/773809005683 Remove the builder parameter from nsDisplayFilters::CreateWebRenderCommands(). r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/29130e26511b Move CreateWebRenderCSSFilters() to nsSVGIntegrationUtils. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/430834640980 Introduce a helper nsSVGIntegrationUtils::CanCreateWebRenderFiltersForFrame(). r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/c278c4ce9447 Use CanCreateWebRenderFiltersForFrame() in ScrollFrameWillBuildScrollInfoLayer(). r=tnikkel https://hg.mozilla.org/integration/autoland/rev/b3d7b5f40cf7 Move UsesSVGEffectsNotSupportedInCompositor() to nsSVGIntegrationUtils. r=tnikkel https://hg.mozilla.org/integration/autoland/rev/504f24d73316 Use UsesSVGEffectsNotSupportedInCompositor() in ShouldBuildScrollInfoItemsForHoisting(). r=tnikkel

Raul Gurzau (:RaulG)

Comment 13

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/ff6a071cf39e
https://hg.mozilla.org/mozilla-central/rev/773809005683
https://hg.mozilla.org/mozilla-central/rev/29130e26511b
https://hg.mozilla.org/mozilla-central/rev/430834640980
https://hg.mozilla.org/mozilla-central/rev/c278c4ce9447
https://hg.mozilla.org/mozilla-central/rev/b3d7b5f40cf7
https://hg.mozilla.org/mozilla-central/rev/504f24d73316

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox71: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla71

Cristian Fogel [:cfogel]

Comment 14

•

5 years ago

Tentative addition of QE+, will be removed if our hardware configuration(s) does allow us to reproduce the issue.

Has STR: --- → yes

Flags: qe-verify+

BugBot [:suhaib / :marco/ :calixte]

Updated

•

5 years ago

Keywords: regression

Alexandru Trif, Desktop QA [:atrif]

Comment 15

•

5 years ago

Hello! Reproduced the issue with Firefox 71.0a1 (20190904163258) on Windows 10x64.
The issue is verified fixed with Firefox 71.0b9 (20191111170815) on Windows 10x64, Ubuntu 18.04 and macOS 10.14. After following the STR from comment 0 the dropdown menu is scrollable while using Webrender.

Status: RESOLVED → VERIFIED

status-firefox71: fixed → verified

Flags: qe-verify+

BugBot [:suhaib / :marco/ :calixte]

Updated

•

3 years ago

Has Regression Range: --- → yes

Botond Ballo [:botond]

Assignee

Updated

•

2 years ago

Regressions: 1787623

You need to log in before you can comment on or make changes to this bug.