Clean up marionette test conditions for Fennec
Categories
(Remote Protocol :: Marionette, task, P3)
Tracking
(firefox71 fixed)
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
testing/marionette/harness/marionette_harness/tests/unit/ code has various @skip_if_mobile conditions, which are no longer required because we won't be running marionette tests against Fennec any longer.
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Geoff, what do all the new dependencies actually mean for this particular bug? Note that we won't be able to run any of those tests with a geckoview application. As such all the tests are desktop only.
Assignee | ||
Comment 3•5 years ago
|
||
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #2)
These are the bug numbers found in fennec references that my patch removes. I was trying to respond to your review comment "We should make sure to add all those known bugs as dependencies". Perhaps I took that too literally?
Some, like bug 1534291, are Fennec-specific test failures. I'd be tempted to close bugs like that as DUPs of this bug, or perhaps as INVALID, with a note that we won't run these tests against Fennec any longer. Others, like bug 1298921, have a wider scope and might be better kept open. Thoughts?
Comment 4•5 years ago
|
||
No worries! It gave me a good overview of remaining issues. Most of them I was able to sort out. There is only bug 1519552 where I need some feedback from James. And bug 1298921 will be fixed later today, or on Monday.
Comment 6•5 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•