Closed Bug 1578920 Opened 5 years ago Closed 5 years ago

Local build failures due to bug 1507754

Categories

(Thunderbird :: Build Config, defect)

Product:
Thunderbird
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr6870+ fixed, thunderbird71 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 71.0
Tracking Flags:
Tracking Status
thunderbird_esr68 70+ fixed
thunderbird71 --- fixed

People

(Reporter: rjl, Assigned: rjl)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

localbuildfixes.patch
(deleted), patch
darktrojan
: review+
jorgk-bmo
: approval-comm-esr68+
Details | Diff | Splinter Review

Various mach configure failures after bug 1507754.
They all seem to involve execution of hg commands failing.

Attached patch localbuildfixes.patch (deleted) — — Splinter Review 
I've tested various scenarios locally, and the try build looks okay so
far.
Attachment #9090526 - Flags: review?(geoff)
Assignee: nobody → rob
Status: NEW → ASSIGNED
Comment on attachment 9090526 [details] [diff] [review]
localbuildfixes.patch

Huh. I'm sure I r+'ed this earlier.
Attachment #9090526 - Flags: review?(geoff) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/64740b4f1270
Bug 1507754 follow-up: fix mach configure failures on local builds. r=darkrojan DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
Comment on attachment 9090526 [details] [diff] [review]
localbuildfixes.patch

[Approval Request Comment]
Regression caused by (bug #): 1507754
User impact if declined: Local builds are likely to fail
Testing completed (on c-c, etc.): This has been on central for a few weeks
Risk to taking this patch (and alternatives if risky): Low but important. It's a developer only affecting bug. There is a high failure rate without this fix.
Attachment #9090526 - Flags: approval-comm-esr60?
Comment on attachment 9090526 [details] [diff] [review]
localbuildfixes.patch

Jörg, I am really sorry, I grabbed the wrong ESR version for approval. Can this make it in to the next build? Kai is hitting this on his local builds.

[Approval Request Comment]
Regression caused by (bug #): 1507754
User impact if declined: Local builds are likely to fail
Testing completed (on c-c, etc.): This has been on central for a few weeks
Risk to taking this patch (and alternatives if risky): Low but important. It's a developer only affecting bug. There is a high failure rate without this fix.
Attachment #9090526 - Flags: approval-comm-esr60? → approval-comm-esr68?
Comment on attachment 9090526 [details] [diff] [review]
localbuildfixes.patch

Sure. You really don't need to fill in the details. I know what most bugs are about.
Attachment #9090526 - Flags: approval-comm-esr68? → approval-comm-esr68+

Thanks, that fixed my local build.

Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: