Fix test that are intermittents when Toolbox is in content frame
Categories
(DevTools :: Framework, task, P1)
Tracking
(firefox71 fixed)
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m1)
Attachments
(2 files)
Tests that force devtools.toolbox.content-frame to false:
- devtools/client/webconsole/test/mochitest/browser_jsterm_screenshot_command_clipboard.js
- devtools/client/shared/test/browser_html_tooltip_consecutive-show.js
- devtools/client/shared/test/browser_treeWidget_keyboard_interaction.js
- devtools/client/shared/test/browser_treeWidget_mouse_interaction.js
They should be fixed so that we can remove the preference.
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Even though we still need to fix those awaits, this removes the need to use the pref in 3 tests.
We should ultimately investigate why our switchHost/createHost can sometimes resolve too early and make the tests fail.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Not exactly sure why this fixes the issue.
Whether we run with a content frame or not, if you run the test on a slow platform,
and if you run the fullpage test a lot of times, you will sometimes see the toolbox become huge very briefly.
When the toolbox runs in a content frame, the screenshot will then not match the content page size.
I will investigate a bit more to get a better understanding, but in the meantime this should fix the issue.
|
|
||
Updated•5 years ago
|
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4f9a8eba6f73
https://hg.mozilla.org/mozilla-central/rev/9529fc074e39
|
||
Updated•5 years ago
|
|
|
||
Updated•3 years ago
|
Description
•