Closed
Bug 1579269
Opened 5 years ago
Closed 5 years ago
Ensure that "InRDMPane" property is set on the window's document when RDM is active
Categories
(DevTools :: Responsive Design Mode, task, P1)
DevTools
Responsive Design Mode
Tracking
(firefox72 fixed)
RESOLVED
FIXED
Firefox 72
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: mtigley, Assigned: bradwerth)
References
(Blocks 1 open bug)
Details
(Whiteboard: fission-rdm-mvp)
Attachments
(2 files, 1 obsolete file)
The existing embedded RDM protoype does not set the InRDMPane property on the document when RDM is enabled. Currently, this is set in https://searchfox.org/mozilla-central/source/devtools/client/responsive/browser/content.js#187 which is no longer being called since removing usage of <mozbrowser>.
This property is used in multiple places on the platform side to simulate various features such as:
Reporter | ||
Updated•5 years ago
|
Priority: -- → P3
Reporter | ||
Comment 1•5 years ago
|
||
Adding an additional actor method on the emulation front called toggleDocumentInRDMPane
and calling this in the Responsive UI manager when opened or closed is likely what we'll need to do for this.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → bwerth
Reporter | ||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Updated•5 years ago
|
Blocks: dt-rdm-fission
Updated•5 years ago
|
Priority: P3 → P2
Updated•5 years ago
|
Assignee: bwerth → nobody
Status: ASSIGNED → NEW
Whiteboard: fission-rdm-mvp
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → bwerth
Updated•5 years ago
|
Status: NEW → ASSIGNED
Priority: P2 → P1
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D51020
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D51021
Updated•5 years ago
|
Attachment #9105079 -
Attachment description: Bug 1579269 Part 3: Add a test of the inRDMPane property. → Bug 1579269 Part 2: Add a test of the inRDMPane property.
Updated•5 years ago
|
Attachment #9105078 -
Attachment is obsolete: true
Assignee | ||
Updated•5 years ago
|
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84560702e4bf
Part 1: Make the document inRDMPane property set via a new emulation actor method. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/393d01dc0de0
Part 2: Add a test of the inRDMPane property. r=mtigley
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/84560702e4bf
https://hg.mozilla.org/mozilla-central/rev/393d01dc0de0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•