Closed
Bug 1579482
Opened 5 years ago
Closed 5 years ago
Header should use var(--in-content-page-background) instead of white
Categories
(Firefox :: about:logins, enhancement, P3)
Tracking
()
VERIFIED
FIXED
Firefox 71
People
(Reporter: ddurst, Assigned: jaws)
References
Details
(Whiteboard: [passwords:management] [skyline])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details |
Header is currently white and should be #F9F9FA -- which is more appropriately var(--in-content-page-background).
|
Reporter | |
Updated•5 years ago
|
Whiteboard: [passwords:management] [skyline]
|
||
Updated•5 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78ea13f0c4e6
Header should use --in-content-page-background. r=sfoster
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
|
|
Assignee | |
Updated•5 years ago
|
status-firefox70:
--- → affected
Comment on attachment 9093688 [details]
Bug 1579482 - Header should use --in-content-page-background. r?sfoster
Polish issue for Skyline feature, OK for beta uplift (part of batch uplift request)
Attachment #9093688 -
Flags: approval-mozilla-beta+
|
|
||
Comment 5•5 years ago
|
||
| bugherder uplift | ||
|
||
Comment 6•5 years ago
|
||
I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20190923215658) and on the Firefox Beta 70.0b9 (Build ID: 20190923154733) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 18.04 x64.
- The header uses var(--in-content-page-background) instead of var(--in-content-box-background).
|
||
Updated•5 years ago
|
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla71 → Firefox 71
Version: unspecified → 70 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•