Search one-offs container has incorrect accessibility role
Categories
(Firefox :: Address Bar, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | unaffected |
firefox70 | + | verified |
firefox71 | --- | verified |
People
(Reporter: Jamie, Assigned: Jamie)
References
(Regression)
Details
(Keywords: access, regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details |
STR (with the NVDA screen reader):
- Press alt+d to focus the address bar.
- Type: test
- Press up arrow. You may need to press it twice if bug 1567384 comment 16 isn't fixed yet.
- Expected: NVDA should say "This time, search with: grouping"
- Actual: NVDA says "This time, search with: box"
This was regressed in bug 1561894. Previously, this was a <description>
with role="group"
. In bug 1561894, the structure was changed and the role="group" was removed.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Comment 3•5 years ago
|
||
bugherder |
Comment 4•5 years ago
|
||
please ask for uplift when possible.
Comment 5•5 years ago
|
||
[Tracking Requested - why for this release]: accessibility regression
Assignee | ||
Comment 6•5 years ago
|
||
Comment on attachment 9091341 [details]
Bug 1579767: Reinstate the accessibility group role for the search one-offs container.
Beta/Release Uplift Approval Request
- User impact if declined: Minor incorrect information reported for accessibility clients such as screen readers.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial patch which just adds a markup attribute that only impacts accessibility.
- String changes made/needed: None.
Comment on attachment 9091341 [details]
Bug 1579767: Reinstate the accessibility group role for the search one-offs container.
Accessibility fix for new regression in 70, let's uplift for beta 7.
Comment 8•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Updated•5 years ago
|
Comment 9•5 years ago
|
||
I have managed to reproduce this issue using Firefox 70.0a1 (BuildId:20190801214227) on Windows 10 64bit (with NVDA enabled).
This issue is verified fixed using Firefox 71.0a1 (BuildId:20190916155843) and Firefox 70.0b7 (BuildId:20190916074538) on Windows 10 64bit with NVDA.
Updated•3 years ago
|
Updated•3 years ago
|
Description
•