Ying-Lin Xia Reporter
	Description • 22 years ago

Currently the mail printing header is sharing same strings with mail 
forward-as-attachment, in file mimeheader.properties. We need to seperate them, 
cause for localization, we need to keep the forward header in English, but 
localize the print header.

	nhottanscp Assignee
	Comment 1 • 22 years ago

This is mail specific.

	Ying-Lin Xia Reporter
	Comment 2 • 22 years ago

This problem is found in bugscape bug 15671:

With the current Ja build, when a mail is printed out, the header lables, like
Subject: To: and etc. are still in English.
Please refer the following fixed i18n bug:
http://bugzilla.mozilla.org/show_bug.cgi?id=86980
and bug for l10n notes:
http://bugzilla.mozilla.org/show_bug.cgi?id=125446,

But please make sure the fix for this bug doesn't introduce regressions to bug 
14230

------- Additional Comment #4 From rchen@netscape.com 2002-07-17 10:49 -------

According to nhotta, we won't localized the header lables, like
Subject: To: and etc. They should be in English.

------- Additional Comment #5 From Naoki Hotta 2002-07-17 11:10 -------

That is true for message compose/send (for JA build). For message view/print, 
we
can localize them. I think the current problem is that the strings are shared
for view and compose.

------- Additional Comment #6 From Ying-Lin Xia 2002-07-17 13:48 -------

Right, I just made a test. The strings in file mimeheader.properties are shared 
by both print and forward-as-attachment. Which means we can not translate it 
now.

	nhottanscp Assignee
	Comment 3 • 22 years ago

There is another file called "mime.properties" which also has "To", "From", etc.

	nhottanscp Assignee
	Comment 4 • 22 years ago

I think I can change nsMimeBaseEmitter::MimeGetStringByName to get the string
differently based on 'mFormat' value. We want to avoid the localized strings to
be quoted and sent out (e.g. to the receiver who cannot handle the localized
strings).
The function currently uses mimeheader.properties. I can change it to use
mime.properties for quoting if we are sure that is not localized.
Basically, either mimeheader.properties or mime.properties has to stay unlocalized.

	Jean-Francois Ducarroz
	Comment 6 • 22 years ago

Comment on attachment 104195 [details] [diff] [review]
Use tranlated strings for headers if not quoting.

R=ducarroz

	David :Bienvenu
	Comment 7 • 22 years ago

I think nsCRT::strcmp is deprecated, though it does check for null args, so if
the strings might be null, you could still use it, I guess.

doesn't this leak val? should we use nsXPIDLString?
+    PRUnichar *val = nsnull;
+
+    res = m_stringBundle->GetStringFromID(aID, &val);
+
+    if (NS_FAILED(res)) 
+      return nsnull;
+
+    return ToNewUTF8String(nsAutoString(val));
+  }

	David :Bienvenu
	Comment 9 • 22 years ago

Comment on attachment 104207 [details] [diff] [review]
Changed to use strcmp, fixed the leaks.

sr=bienvenu

	nhottanscp Assignee
	Comment 10 • 22 years ago

checked in to the trunk