Remove Fennec build system support and source code
Categories
(Firefox Build System :: Android Studio and Gradle Integration, task)
Tracking
(firefox71 fixed)
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
(Blocks 5 open bugs)
Details
Attachments
(3 files, 10 obsolete files)
Bug 1570411 added a --without-fennec
flag, but didn't do anything to act on that flag during the build. This ticket tracks doing some of that.
It's possible we just want to delete all this code rather than guarding it, since it's now the 71 cycle, but I started down this path so I'll continue for a while.
Assignee | ||
Comment 1•5 years ago
|
||
GeckoView builds produce artifact for download by Mozilla's regular
consumer audience. It's not clear what, if anything, depends on this
download information, but this is a reasonable way to find out!
Assignee | ||
Comment 2•5 years ago
|
||
This does a few things when --without-fennec:
- stops producing (and consuming)
FennecJNI*
JNI wrappers - removes the :app and :thirdparty Gradle projects
- removes relevant pieces of the Gradle target configuration
- updates lints
Depends on D46535
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D46536
Assignee | ||
Comment 4•5 years ago
|
||
Try builds:
artifact, --without-fennec
: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3f59dfd6d041ecc636d6035f6d53b28911e8c1c
full, --without-fennec
: https://treeherder.mozilla.org/#/jobs?repo=try&revision=18862015914957b5bbd19e9927a50148509359ae
--with-fennec
is busted in automation: I'll need to update the Gradle dependencies. Or get rid of with{out}GeckoBinaries
, which isn't really needed after Bug 1550146.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
Depends on D46535
Updated•5 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
Depends on D46536
Assignee | ||
Comment 7•5 years ago
|
||
Depends on D47697
Assignee | ||
Comment 8•5 years ago
|
||
Depends on D47698
Assignee | ||
Comment 9•5 years ago
|
||
Depends on D47699
Assignee | ||
Comment 10•5 years ago
|
||
Depends on D47700
Assignee | ||
Comment 11•5 years ago
|
||
Depends on D47701
Updated•5 years ago
|
Assignee | ||
Comment 12•5 years ago
|
||
Per @snorp's suggestion, I made this tear out (most of) Fennec. I will file some follow-ups as I have energy.
To my reviewers, all of the "TO FOLD" pieces will be collapsed into the main commit, which will land all at once.
To @snorp: I suggest downloading the patch and looking at the diffstat
locally. Good luck making sense of anything in Phab :(
Assignee | ||
Comment 13•5 years ago
|
||
A try build with Android N
builds, including l10n:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=60f35f7b06fc4e059294b2299c88647486e0331c
A try build with Linux 64 builds, to catch configure
errors:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f2b3b437e3aa6ff89ed4e44761787b18e346666
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 14•5 years ago
|
||
It's not clear to me what "signing" a Maven artifact means: doubtless
there's a way to include GPG signatures. But we don't do it at this
time, and these tasks require Fennec APKs, so we remove them.
Depends on D47702
Assignee | ||
Comment 15•5 years ago
|
||
Depends on D47955
Assignee | ||
Comment 16•5 years ago
|
||
Depends on D47956
Updated•5 years ago
|
Assignee | ||
Comment 17•5 years ago
|
||
"Big try build" percolating at https://treeherder.mozilla.org/#/jobs?repo=try&revision=af5eb485915d4bc2a29f21e9f4e5ae0d8b2c0632.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 18•5 years ago
|
||
Assignee | ||
Comment 19•5 years ago
|
||
Sheriffs: hopefully this sticks -- it's a huge patch, I really don't want to rebase it, etc. Try was basically happy: https://treeherder.mozilla.org/#/jobs?repo=try&revision=af5eb485915d4bc2a29f21e9f4e5ae0d8b2c0632.
Comment 20•5 years ago
|
||
This shouldn't have touched l10n.toml. See conversation in
https://bugzilla.mozilla.org/show_bug.cgi?id=1582218#c1
I'm going to see if sheriffs can land a follow-up reverting this specific change before it merges to m-c
https://hg.mozilla.org/integration/autoland/diff/1ffe2e3d6e19a351575ac986c43155ed8e8d90bc/mobile/android/locales/l10n.toml
Comment 21•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6f7cf55ea869
https://hg.mozilla.org/mozilla-central/rev/2009acbb8bfa
https://hg.mozilla.org/mozilla-central/rev/1ffe2e3d6e19
Comment 22•5 years ago
|
||
Assignee | ||
Comment 23•5 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #20)
This shouldn't have touched l10n.toml. See conversation in
https://bugzilla.mozilla.org/show_bug.cgi?id=1582218#c1I'm going to see if sheriffs can land a follow-up reverting this specific change before it merges to m-c
https://hg.mozilla.org/integration/autoland/diff/1ffe2e3d6e19a351575ac986c43155ed8e8d90bc/mobile/android/locales/l10n.toml
Sorry, flod: you are right that there was a discussion (in Phab?) but I though I had restricted myself to changes that weren't relevant across trees. Sorry that I didn't get an l10n peer's review, and thanks for filing the follow-up very quickly.
Description
•