remove unnecessary files from comm/mail/components/compose
Categories
(Thunderbird :: Message Compose Window, task)
Tracking
(Not tracked)
People
(Reporter: khushil324, Assigned: khushil324)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
After Bug 1571687, there are few files in comm/mail/components/compose that we don't use in Thunderbird. I will be removing those files through this bug.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Comment 3•5 years ago
|
||
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
||
Comment 5•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1ff6192e719f
remove unnecessary files from compose directory. r=mkmelin
Accidentally landed in bug 1580251 comment #2 due to an incorrect bug number in the patch :-(
How do we know we don't use those?
Just because there is no direct button to open the dialog on the HTML composer toolbar yet?
|
|
||
Comment 7•5 years ago
|
||
Good question. I looked at it and came to the conclusion that we don't use buttons, field sets, forms, inputs, labels, pages, selects and text areas. I hope author and reviewer checked it thoroughly. Anyway, we'll find out when TB 76 ships ;-)
|
|
||
Comment 8•5 years ago
|
||
These are (almost) all form controls. But I can't think of good reasons to have forms controls in an email, and we prevent people from filling them if received too.
Direct html input will still work, but you don't get any helper dialog to adjust the element. Even today you'd still have to enter the raw html to even get into a situation where you could open such a dialog.
Description
•