Fix usage of nsIDocShellTreeItem in nsDocShell::CheckLoadingPermission
Categories
(Core :: DOM: Navigation, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: djvj, Assigned: smacleod)
References
(Blocks 1 open bug)
Details
(Whiteboard: [rm-docshell-tree-item:simple])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The issue here is that the docshell tree (same-type) is walked up, stopping and returning true at the first ancestor docshell which has a principal which is subsumed by the subject principal.
I suspect this information is unlikely to be shared cross process. Do we have some mechanism to query this via IPC already, or does an implementation need to be added?
Reporter | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
(In reply to Kannan Vijayan [:djvj] from comment #0)
The issue here is that the docshell tree (same-type) is walked up, stopping and returning true at the first ancestor docshell which has a principal which is subsumed by the subject principal.
This should be straightforward enough to fix. the subject principal will never subsume the principal of an iframe in a different process, so we can walk up the BrowsingContext tree, and assume that the subsume check fails for BCs with missing DocShells.
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).
Reporter | ||
Comment 3•5 years ago
|
||
Updated•5 years ago
|
Comment 4•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:djvj, could you have a look please?
For more information, please visit auto_nag documentation.
Reporter | ||
Comment 5•5 years ago
|
||
The patch was r+ but I was running into testing errors that I could not resolve before I went on PTO. I'll take a look at this when I get back to work. Keeping needinfo.
Reporter | ||
Comment 6•5 years ago
|
||
I can't really get back to this - I have one major and another minor thing on my plate currently which I should focus on. Anyone should feel free to take/work on this.
Comment 7•5 years ago
|
||
Auditing whether this use of nsIDocShellTreeItem breaks when Fission is enabled blocks Fission Nightly.
Updated•4 years ago
|
Comment 9•4 years ago
|
||
bugherder |
Description
•