Closed
Bug 1581014
Opened 5 years ago
Closed 5 years ago
about:logins list item selection can go directly to edit mode
Categories
(Firefox :: about:logins, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 71
People
(Reporter: ddurst, Assigned: jaws)
References
Details
(Whiteboard: [passwords:management] [skyline])
Attachments
(1 file)
If I'm going through the login list (using the keyboard), pressing Enter will select the item and put focus on the login-item's edit button, as reported in 1576026.
But if instead of pressing Enter, I press Space, it immediately pulls up the login-item in Edit mode.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: -- → P1
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a2fac1bae9d
Select the login item on keyup instead of keydown to prevent the 'Edit' button, which gets focused on login selection, from getting an erroneous click event. r=MattN
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20190918100042) (64-bit) on Windows 7, MacOS 10.14 and Arch Linux 4.14.
- The focused saved login is no longer opened directly in "Edit" mode if pressing the "Space".
Status: RESOLVED → VERIFIED
|
|
Assignee | |
Comment 5•5 years ago
|
||
| bugherder uplift | ||
I have verified this issue on the Firefox Beta 70.0b9 (Build ID: 20190923154733) (64-bit) on Windows 7, MacOS 10.14 and Arch 4.14.
- The focused saved login is no longer opened directly in "Edit" mode if pressing the "Space".
|
||
Updated•5 years ago
|
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla71 → Firefox 71
Version: unspecified → 70 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•