STR:

1. While on bugzilla, inspect #page-toolbar
2. Toggle the flex highlighter on
3. Change the highlighter color

ER: Color of both lines and background pattern should change

AR: Only color of lines changes, background pattern remains the same

This is happening because we cache these patterns and their color. https://searchfox.org/mozilla-central/source/devtools/server/actors/highlighters/flexbox.js#243,249,292,298.

A potential fix is to store the previous color, and when that changes, we invalidate and remove all the patterns in these caches. We would make this change inside of _update() just before we render the lines. https://searchfox.org/mozilla-central/source/devtools/server/actors/highlighters/flexbox.js#865

Hi everyone,

Could I give this a try?

Thanks!

(In reply to Mellina Yonashiro from comment #2)

Hi everyone,

Could I give this a try?

Thanks!

Yes, of course. Please let me know if I can help.

Thanks, Gabriel.

I had some issues building Firefox, but things are working now. I will have a look at this bug as soon as it is done.

Hi Mellina, it looks like Gabriel made a few last comments in phabricator about your patch. Are you still planning on working on it?
If you just need more time, that's totally fine. Just let us know.

Hi Patrick, sorry for the late reply.
I saw it, but I didn't have time to look at it. I have time tomorrow and will work on it.
Sorry again.

https://hg.mozilla.org/mozilla-central/rev/3a9dba929c84