non-aligned columns in account creation wizard In some locales
Categories
(Thunderbird :: Account Manager, defect)
Tracking
(thunderbird_esr6869+ fixed)
People
(Reporter: aceman, Assigned: khushil324)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
bug-TB-account-wizard-grid.png
It seems after removal of <grid> in bug 1527003 the account creation wizard is now not properly aligned in columns. See the screenshot.
This is in TB68, while later version have the wizard reworked, but should also be checked if this is fixed properly in there.
We should fix this in 68 anyway as it is the first dialog new users see and it looks unprofessional. And whatever is in 69+ won't get into 68 in the next year.
|
||
Comment 1•5 years ago
|
||
Must be because of the long second label in that locale. English is fine.
Sure, but a grid or a proper replacement wouldn't have a problem with that. I hope there are no fixed widths set on the elements.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 5•5 years ago
|
||
So this is a TB 68-only patch? Account creation was changed completely in bug 1551133.
|
|
||
Comment 9•5 years ago
|
||
Well, https://hg.mozilla.org/releases/comm-esr68/rev/e8c17fa950fa can be backed out cleanly. You want me to do that? Quite a big patch/change.
|
|
||
Comment 10•5 years ago
|
||
TB 68.1.1 or TB 68.2:
https://hg.mozilla.org/releases/comm-esr68/rev/74288646087137679bf794bfbb8f161ccb1916fd
(Hopefully) fixed via backout of bug 1527003.
|
|
||
Comment 11•5 years ago
|
||
Comment on attachment 9092970 [details] [diff] [review] Bug-1581388_non-aligned-columns_account-creation.patch Patch looked simple enough to me, but Magnus asked for a backout. Let's see what the result looks like.
|
|
||
Updated•5 years ago
|
Description
•