devicechange notifications are triggered with any device change, not just video and audio devices. For instance, plugging/unplugging a USB flash disk creates a device change notification.

After Bug 1581193 devicechange notifications were triggered with any device change, not just video and audio devices. This patch limits down the notifications to only video and audio input devices change.

https://hg.mozilla.org/mozilla-central/rev/1feec83ee6f9

Please request Beta approval on this.

Comment on attachment 9093285 [details]
Bug 1581806 - Trigger devicechange event for audio and video input devices only. r?dminor

Beta/Release Uplift Approval Request

• User impact if declined: devicechange notifications are triggered with any device change, not just video and audio devices. For instance, plugging/unplugging a USB flash disk creates a device change notification.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Steps are mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1581193#c0
• List of other uplifts needed: Bug 1581193
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is low risk because it does not alter much the way that it already works, it only filters out the non-media devices.
• String changes made/needed: N/A

Hi Alex, I tried to reproduce the issue on Firefox Nightly 71.0a1 (2019-09-19 and respectively 2019-09-22) under Ubuntu 18.04 (x64) with a usb flash disk, but couldn't trigger the "device change!" message at all. Are there some extra steps that I should follow or something else to do? Thanks!

This is landed in 2019-09-18 so it should be fixed in 2019-09-19 and you wont be able to reproduce it after that. Try the Nightly from 2019-09-18 to reproduce it. Also, I was using fedora but I don't think it affects that scenario.

Comment on attachment 9093285 [details]
Bug 1581806 - Trigger devicechange event for audio and video input devices only. r?dminor

Part of the fix for regression in 1581193. OK for uplift for beta 10.

https://hg.mozilla.org/releases/mozilla-beta/rev/7354577a6ec4

I successfully reproduced the issue on Firefox Nightly 71.0a1 (2019-09-18) under Windows 10 x64 using a usb keyboard device (thanks for the infos Alex).

The issue is no longer reproducible on latest Nightly 71.0a1 (2019-09-24) and Firefox Beta 70.0b9. Tests were performed on Windows 10 (x64), Ubuntu 16.04 (x64) and macOS 10.14.