Closed
Bug 1581989
Opened 5 years ago
Closed 5 years ago
Tip results aren't properly accounted for in histogram telemetry
Categories
(Firefox :: Address Bar, defect, P2)
Firefox
Address Bar
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
UrlbarController.recordSelectedResult is called when a result is picked. Bug 1578433 added a new case statement for tips, but we didn't update URLBAR_SELECTED_RESULT_TYPES, so the two histograms at the bottom of that method won't actually be updated. My fault for not realizing the obvious.
We should add a test called browser_UsageTelemetry_urlbar_tip.js modeled on these tests:
- https://searchfox.org/mozilla-central/source/browser/modules/test/browser/browser_UsageTelemetry_urlbar.js (this is for search results)
- https://searchfox.org/mozilla-central/source/browser/modules/test/browser/browser_UsageTelemetry_urlbar_extension.js
- https://searchfox.org/mozilla-central/source/browser/modules/test/browser/browser_UsageTelemetry_urlbar_places.js
- https://searchfox.org/mozilla-central/source/browser/modules/test/browser/browser_UsageTelemetry_urlbar_remotetab.js
|
Assignee | |
Comment 1•5 years ago
|
||
This should also be a break, not a return: https://searchfox.org/mozilla-central/rev/1d0e84d2ec2843924bc6e5ed6658f93439e12351/browser/components/urlbar/UrlbarController.jsm#520
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 71.2 - Sept 16 - 29
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/73e41954d0f7
Properly account for tip results in histogram telemetry. r=harry
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in
before you can comment on or make changes to this bug.
Description
•