Closed Bug 1582086 Opened 5 years ago Closed 5 years ago

toolkit/components/search/tests/xpcshell/test_json_cache_good.js and toolkit/components/search/tests/xpcshell/test_json_cache_broken.js fail when run as part of the Thunderbird Xpcshell tests

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

1582086-disable-tests.patch - with comments
(deleted), patch
standard8
: review+
Details | Diff | Splinter Review

These tests were created in bug 1578807. We see:
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_json_cache_good.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_json_cache_good.js | test_cached_engine_properties - [test_cached_engine_properties : 155] Should have recorded the engines cache as not corrupted - "undefined" == false
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_json_cache_broken.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_json_cache_broken.js | test_cached_engine_properties - [test_cached_engine_properties : 134] Should have recorded the engines cache as corrupted - "undefined" == true

Mark, can you please give us a tip what we need to do in TB to get them working. Or should they simply be disabled?

Flags: needinfo?(standard8)

Sounds like Thunderbird hasn't recorded any telemetry for the new scalar. Does Thunderbird not have telemetry enabled, even for tests?

Flags: needinfo?(standard8)

Thanks, Mark. We're working on telemetry in bug 1427877. I'll run the test locally and see what needs to be disabled.

Attached patch 1582086-disable-tests.patch (obsolete) (deleted) — — Splinter Review

I don't think it makes much sense trying to disable parts of the tests.

Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #9093741 - Flags: review?(standard8)
Comment on attachment 9093741 [details] [diff] [review] 1582086-disable-tests.patch Review of attachment 9093741 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/search/tests/xpcshell/xpcshell.ini @@ +69,2 @@ > [test_json_cache_good.js] > +skip-if = appname == "thunderbird" You might want to add a comment about why these are disabled, and a bug number if you're planning on re-enabling these later once you've got telemetry up and running.
Attachment #9093741 - Flags: review?(standard8)
Attachment #9093741 - Attachment is obsolete: true
Attachment #9093857 - Flags: review?(standard8)
Attachment #9093857 - Flags: review?(standard8) → review+

Thanks, Mark.

Dear Sheriff, this bug came from the Thunderbird product and has an "old-fashioned" patch. Please land it for me.

Component: General → Search
Keywords: checkin-needed
Product: Thunderbird → Firefox

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89b9b3aa3aaf
disable test_json_cache_{good|broken}.js for Thunderbird. r=standard8

Keywords: checkin-needed

(In reply to Jorg K (GMT+2) from comment #6)

Thanks, Mark.

Dear Sheriff, this bug came from the Thunderbird product and has an "old-fashioned" patch. Please land it for me.

Done :)

https://hg.mozilla.org/mozilla-central/rev/89b9b3aa3aaf

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: