It fails within the test_schemeUpgrade subtest as the dialog does not appear.

I traced this as far as nsHttpChannelAuthProvider::PromptForIdentity not showing the dialog.

(In reply to Neil Deakin from comment #0)

I traced this as far as nsHttpChannelAuthProvider::PromptForIdentity not showing the dialog.

Should I move this bug to Necko or is that work already being tracked and can be marked as a dependency?

I haven't triaged any of the remaining disabled password manager tests enough to know for sure what the cause of them is. I haven't filed any other bugs.

FAIL Checking expected message - got "http://example.com is requesting your username and password. The site says: “schemeDowngrade”", expected "http://example.com is requesting your username and password. WARNING: Your password will not be sent to the website you are currently visiting!"

FAIL Checking expected message - got "https://example.org is requesting your username and password. The site says: “schemeUpgradeDedupe”", expected "https://example.org is requesting your username and password. WARNING: Your password will not be sent to the website you are currently visiting!"

This is a bug in Necko: https://searchfox.org/mozilla-central/rev/62a130ba0ac80f75175e4b65536290b52391f116/netwerk/protocol/http/nsHttpChannelAuthProvider.cpp#933-948,1181-1182 needs to properly compare the top level URI with the auth channel URI in a Fission-compatible way.

The prompt code then uses this flag at https://searchfox.org/mozilla-central/rev/62a130ba0ac80f75175e4b65536290b52391f116/toolkit/components/prompts/src/Prompter.jsm#324-325,353-357

Once bug 1582116 lands, toolkit/components/passwordmgr/test/mochitest/test_prompt_async.html will also be fixed by this bug and should be enabled here.

Junior, could you take a look at this?

In test_prompt_http.html,
The loadinfo from document channel child wrongly shows its a TYPE_DOCUMENT instead of TYPE_SUBDOCUMENT, which fails this check

Turning off document channel works well even if it's fission enabled. (i.e., document channel + fission would fail)
P1 since it looks bad that we could have wrong ExternalContentPolicyType.

Matt, is it a known issue?

Junior, thanks for looking at this test. I'm tentatively assigning this bug to you until we determine whether it's a Necko bug or DocumentChannel bug.

Is this the same issue as bug 1594529?

Yes, I believe it's the same issue. WIP patches fix test_prompt_http.html but leads crash in test_prompt_async.html
Thanks, Matt.

align priority with bug 1594529

I don't see crashes in (test_prompt_async.html) when I also use the dependent patch: https://bugzilla.mozilla.org/show_bug.cgi?id=1583254 (https://phabricator.services.mozilla.com/D56220) do you have a try stack trace of that or platform details?

Ah I see the crash:

 3:37.65 GECKO(21767) [Child 22157, Main Thread] WARNING: This content process hasn't received the permissions for http://mochi.test:8888 yet: file /home/jonathan/projects/mozilla-unified/extensions/permissions/nsPermissionManager.cpp, line 3158
 3:37.65 GECKO(21767) Assertion failure: PermissionAvailable(prin, aType), at /home/jonathan/projects/mozilla-unified/extensions/permissions/nsPermissionManager.cpp:2284
[21738, Main Thread] WARNING: 'result.isErr()', file /home/jonathan/projects/mozilla-unified/startupcache/StartupCache.cpp, line 167
[21738, Main Thread] WARNING: 'result.isErr()', file /home/jonathan/projects/mozilla-unified/startupcache/StartupCache.cpp, line 167
[21738, Main Thread] WARNING: 'result.isErr()', file /home/jonathan/projects/mozilla-unified/startupcache/StartupCache.cpp, line 167
 3:38.71 GECKO(21767) #01: nsPermissionManager::CommonTestPermissionInternal(nsIPrincipal*, nsIURI*, mozilla::OriginAttributes const*, int, nsTSubstring<char> const&, unsigned int*, bool, bool) (/home/jonathan/projects/mozilla-unified/extensions/permissions/nsPermissionManager.cpp:2284)

Yes exactly the same.

Local test is passed. Let's see if treeherder happy

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1b6ed30d327db7f564639c9b39b93d728b4f2a2&selectedTaskRun=dmxvhcy6SiyWPxecxsthXg-0

Looks good

https://hg.mozilla.org/mozilla-central/rev/764bc18cb7c4