Closed Bug 1582150 Opened 5 years ago Closed 5 years ago

`RuntimeSettingsTest.aboutConfig` disabled

Categories

(GeckoView :: General, defect, P3)

Product:
GeckoView
Component:
General
Platform:
Unspecified
All
Type:
defect

Tracking

(firefox70 wontfix, firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox70 --- wontfix
firefox71 --- fixed

People

(Reporter: snorp, Assigned: agi)

References

Details

Attachments

(1 file)

Bug 1582150 - Don't rely on page stop in aboutConfig test.
(deleted), text/x-phabricator-request
Details

This currently fails due to some raciness with the nsILoadURIDelegate registration when switching processes. It may be fixed by bug 1570115.

Priority: -- → P3

Trying to access about:config will fail even before the page has started loading so we don't get the usual flow.

For a normal page (that fails to load) it is:

  • OnLoadRequest
  • OnPageStart
  • OnLoadError
  • OnPageStop

but for about:config it's just

  • OnLoadRequest
  • OnLoadError

So we just wait for the OnLoadError message instead.

Verified that Bug 1570115 fixes it with a little patch on the test itself (onPageStop is not called for blocked about:config so we need to use onLoadError instead).

Assignee: nobody → agi
Depends on: 1570115
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/85248a084397 Don't rely on page stop in aboutConfig test. r=snorp

https://hg.mozilla.org/mozilla-central/rev/85248a084397

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: