Closed Bug 1583267 Opened 5 years ago Closed 5 years ago

The website's favicon from the login item changes to the default one if the saved login is edited

Categories

(Firefox :: about:logins, defect, P2)

Product:
Firefox
Component:
about:logins
Version:
70 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox70 --- verified
firefox71 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [passwords:management] [skyline])

Attachments

(1 file)

Bug 1583267 - Restore the cached website favicon when the login is updated. r?MattN
(deleted), text/x-phabricator-request
lizzard
: approval-mozilla-beta+
Details

The patch in bug 1577513 was rebased incorrectly prior to landing. The change was made to loginAdded instead of loginModified.

Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7495f0c10ce Restore the cached website favicon when the login is updated. r=MattN

https://hg.mozilla.org/mozilla-central/rev/f7495f0c10ce

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

I have verified this issue and is no longer reproducible on the latest Nightly 71.0a1 (Build ID: 20190924215237) on Windows 7 x64, Mac 10.14 and Arch 14.14 x64.

  • The website's favicon is correctly displayed if the saved login is edited.
Status: RESOLVED → VERIFIED
status-firefox71: fixed → verified

Does this need a Beta uplift request?

Flags: needinfo?(jaws)
Whiteboard: [passwords:management] [skyline]
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla71 → Firefox 71
Version: unspecified → 70 Branch

Comment on attachment 9094630 [details]
Bug 1583267 - Restore the cached website favicon when the login is updated. r?MattN

Beta/Release Uplift Approval Request

  • User impact if declined: the favicon will disappear from a login until the about:logins page is refreshed when it is edited
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Patch has been on Nightly for over two weeks.
  • String changes made/needed: none
Flags: needinfo?(jaws)
Attachment #9094630 - Flags: approval-mozilla-beta?

Comment on attachment 9094630 [details]
Bug 1583267 - Restore the cached website favicon when the login is updated. r?MattN

Fix for Skyline issue, let's uplift for beta 14.

Attachment #9094630 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

I have verified this issue on the Firefox Beta 70.0b14 (Build ID: 20191010142853) on Windows 10 x64, Mac 10.15, Ubuntu 16 x64.

  • The website's favicon is now correctly displayed after editing and saving the login details.
status-firefox70: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: