Closed
Bug 1583377
Opened 5 years ago
Closed 5 years ago
Remove xul:page and migrate consumers to xul:window
Categories
(Toolkit :: XUL Widgets, task, P5)
Toolkit
XUL Widgets
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We have 5 non-test consumers of <xul:page> in m-c right now: https://searchfox.org/mozilla-central/search?q=%3Cpage&path=.xul.
According to https://developer.mozilla.org/en-US/docs/Archive/Mozilla/XUL/page, the xul:page element is "similar to a window, except it should be used for XUL files that are to be loaded into an iframe."
But the only handling for page beyond a being a generic XUL element I see is:
- One relevant match on nsGkAtoms::page https://searchfox.org/mozilla-central/search?q=symbol:_ZN9nsGkAtoms4pageE&redirect=false that lumps it in with other root xul elements at https://searchfox.org/mozilla-central/rev/153feabebc2d13bb4c29ef8adf104ec1ebd246ae/layout/xul/nsBoxFrame.cpp#953.
- Some CSS, but all of this applies to <window> and other roots as well: https://searchfox.org/mozilla-central/search?q=%5Epage&case=false®exp=true&path=.css.
So, I'd like to find out if there's a reason we couldn't migrate the consumers directly to <window> (with the ultimate goal of then migrating those to <html>).
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Comment 2•5 years ago
|
||
I see some hits in comm-central too: https://searchfox.org/comm-central/search?q=%3Cpage&case=false®exp=false&path=
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e303e9cc8548
Remove xul:page and replace consumers with xul:window r=NeilDeakin
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•