Closed Bug 1583378 Opened 5 years ago Closed 5 years ago

126,700 instances of "'!mWindow->GetCurrentInnerWindow()'" emitted from dom/ipc/nsQueryActor.h during linux64 debug testing

Categories

(Core :: DOM: Content Processes, defect)

Product:
Core
Component:
DOM: Content Processes
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: erahm, Assigned: agi)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1583378 - Remove unneded warning in do_QueryActor.
(deleted), text/x-phabricator-request
Details

126652 WARNING: '!mWindow->GetCurrentInnerWindow()', file dom/ipc/nsQueryActor.h, line 20

This warning [1] shows up in the following test suites:

  2590 - test-linux64/debug-mochitest-e10s-9 9
  2590 - test-linux64/debug-mochitest-sw-e10s-9 9
  2587 - test-linux64/debug-mochitest-fis-e10s-9 9
  2031 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
  1777 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
  1777 - test-linux64/debug-web-platform-tests-sw-e10s-14 wpt14
  1761 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
  1761 - test-linux64/debug-web-platform-tests-sw-e10s-8 wpt8
  1720 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-12 dt12
  1720 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-12 dt12
  1720 - test-linux64/debug-mochitest-devtools-chrome-e10s-12 dt12
  1557 - test-linux64/debug-web-platform-tests-sw-e10s-18 wpt18
  1557 - test-linux64/debug-web-platform-tests-e10s-18 wpt18
  1551 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
  1551 - test-linux64/debug-web-platform-tests-sw-e10s-1 wpt1
  1539 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-8 bc8
  1463 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
  1463 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-8 dt8
  1383 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-10 dt10
  1383 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
  1383 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-10 dt10
  1365 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-8 dt8
  1192 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
  1190 - test-linux64/debug-web-platform-tests-sw-e10s-7 wpt7
  1099 - test-linux64/debug-mochitest-webgl1-ext-sw-e10s gl1e
  1099 - test-linux64/debug-mochitest-webgl1-ext-e10s gl1e
  1099 - test-linux64/debug-mochitest-webgl1-ext-fis-e10s gl1e
  1025 - test-linux64/debug-web-platform-tests-sw-e10s-9 wpt9
  1025 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
  1024 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-9 dt9
  1024 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
  1008 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-12 bc12
   988 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-9 dt9
   940 - test-linux64/debug-web-platform-tests-sw-e10s-5 wpt5
   938 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
   912 - test-linux64/debug-web-platform-tests-sw-e10s-4 wpt4
   912 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
   877 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-10 bc10
   858 - test-linux64/debug-mochitest-sw-e10s-13 13
   858 - test-linux64/debug-mochitest-e10s-13 13
   855 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
   855 - test-linux64/debug-mochitest-fis-e10s-13 13
   849 - test-linux64/debug-mochitest-chrome-1proc-2 c2
   848 - test-linux64/debug-mochitest-chrome-sw-1proc-2 c2
   840 - test-linux64/debug-mochitest-e10s-2 2
   840 - test-linux64/debug-mochitest-sw-e10s-2 2
   805 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
   803 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-1 dt1
   803 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-7 dt7
   748 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
   748 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-7 dt7
   703 - test-linux64/debug-mochitest-e10s-8 8
   698 - test-linux64/debug-mochitest-sw-e10s-8 8
   682 - test-linux64/debug-mochitest-webgl1-core-sw-e10s gl1c
   682 - test-linux64/debug-mochitest-webgl1-core-e10s gl1c
   682 - test-linux64/debug-mochitest-webgl1-core-fis-e10s gl1c
   681 - test-linux64/debug-web-platform-tests-sw-e10s-17 wpt17
   679 - test-linux64/debug-web-platform-tests-e10s-17 wpt17
   672 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-3 dt3
   668 - test-linux64/debug-mochitest-devtools-chrome-e10s-11 dt11
   668 - test-linux64/debug-mochitest-chrome-1proc-3 c3
   668 - test-linux64/debug-mochitest-chrome-sw-1proc-3 c3
   668 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-11 dt11
   664 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-11 dt11
   641 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
   638 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-16 bc16
   638 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-7 bc7
   631 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-16 bc16
   628 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-2 dt2
   612 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
   584 - test-linux64/debug-mochitest-fis-e10s-8 8
   584 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-2 dt2
   580 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
   580 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-3 dt3
   568 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-1 dt1
   566 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
   565 - test-linux64/debug-reftest-e10s-2 R2
   565 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
   565 - test-linux64/debug-reftest-no-accel-sw-e10s-2 Ru2
   565 - test-linux64/debug-reftest-sw-e10s-2 R2
   550 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
   550 - test-linux64/debug-web-platform-tests-sw-e10s-16 wpt16
   543 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-5 bc5
   534 - test-linux64/debug-mochitest-fis-e10s-2 2
   524 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
   524 - test-linux64/debug-web-platform-tests-sw-e10s-2 wpt2
   522 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
   522 - test-linux64/debug-web-platform-tests-sw-e10s-6 wpt6
   505 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-4 dt4
   505 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
   502 - test-linux64/debug-crashtest-e10s C
   496 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-6 dt6
   495 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-5 dt5
   493 - test-linux64/debug-web-platform-tests-wdspec-e10s-1 Wd1
   493 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-1 Wd1
   491 - test-linux64/debug-crashtest-sw-e10s C
   490 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-6 dt6
   490 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
   476 - test-linux64/debug-mochitest-e10s-15 15
   476 - test-linux64/debug-mochitest-sw-e10s-15 15
   471 - test-linux64/debug-mochitest-sw-e10s-5 5
   471 - test-linux64/debug-mochitest-e10s-5 5
   469 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
   468 - test-linux64/debug-mochitest-fis-e10s-5 5
   464 - test-linux64/debug-mochitest-chrome-sw-1proc-1 c1
   464 - test-linux64/debug-mochitest-chrome-1proc-1 c1
   459 - test-linux64/debug-mochitest-e10s-7 7
   458 - test-linux64/debug-mochitest-sw-e10s-7 7
   451 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
   450 - test-linux64/debug-web-platform-tests-sw-e10s-10 wpt10
   449 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-4 dt4
   445 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-5 dt5
   439 - test-linux64/debug-marionette-e10s Mn
   423 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
   422 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-15 bc15
   406 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
   404 - test-linux64/debug-web-platform-tests-sw-e10s-11 wpt11
   397 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
   393 - test-linux64/debug-mochitest-fis-e10s-7 7
   392 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-15 bc15
   380 - test-linux64/debug-mochitest-fis-e10s-15 15
   372 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
   365 - test-linux64/debug-web-platform-tests-sw-e10s-12 wpt12
   365 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
   356 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
   353 - test-linux64/debug-mochitest-sw-e10s-14 14
   353 - test-linux64/debug-mochitest-e10s-14 14
   352 - test-linux64/debug-web-platform-tests-e10s-15 wpt15
   351 - test-linux64/debug-web-platform-tests-sw-e10s-15 wpt15
   349 - test-linux64/debug-mochitest-fis-e10s-14 14
   346 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-9 bc9
   345 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-4 bc4
   335 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-1 bc1
   309 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-2 Wd2
   309 - test-linux64/debug-web-platform-tests-wdspec-e10s-2 Wd2
   291 - test-linux64/debug-web-platform-tests-e10s-13 wpt13
   289 - test-linux64/debug-web-platform-tests-sw-e10s-13 wpt13
   286 - test-linux64/debug-web-platform-tests-sw-e10s-3 wpt3
   284 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-2 bc2
   284 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
   283 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-9 bc9
   279 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
   278 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
   278 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-13 bc13
   271 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-3 bc3
   269 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
   265 - test-linux64/debug-mochitest-media-fis-e10s-1 mda1
   265 - test-linux64/debug-mochitest-media-sw-e10s-1 mda1
   265 - test-linux64/debug-mochitest-media-e10s-1 mda1
   264 - test-linux64/debug-mochitest-media-spi-e10s-1 mda1
   258 - test-linux64/debug-mochitest-e10s-10 10
   258 - test-linux64/debug-mochitest-sw-e10s-10 10
   251 - test-linux64/debug-mochitest-fis-e10s-10 10
   238 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
   238 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-1 Wr1
   228 - test-linux64/debug-test-verify-e10s TV
   225 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-2 bc2
   221 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-4 bc4
   220 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-3 bc3
   220 - test-linux64/debug-mochitest-media-e10s-2 mda2
   220 - test-linux64/debug-mochitest-media-sw-e10s-2 mda2
   220 - test-linux64/debug-mochitest-media-fis-e10s-2 mda2
   218 - test-linux64/debug-mochitest-media-spi-e10s-2 mda2
   211 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-5 bc5
   211 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
   209 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-14 bc14
   207 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-3 Wr3
   207 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
   207 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
   203 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-12 bc12
   189 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-11 bc11
   186 - test-linux64/debug-mochitest-sw-e10s-12 12
   186 - test-linux64/debug-mochitest-e10s-12 12
   186 - test-linux64/debug-mochitest-fis-e10s-12 12
   185 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-14 bc14
   183 - test-linux64/debug-reftest-no-accel-sw-e10s-8 Ru8
   183 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
   182 - test-linux64/debug-reftest-sw-e10s-8 R8
   181 - test-linux64/debug-reftest-e10s-8 R8
   180 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-2 Wr2
   180 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
   177 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
   177 - test-linux64/debug-reftest-sw-e10s-1 R1
   177 - test-linux64/debug-reftest-no-accel-sw-e10s-1 Ru1
   177 - test-linux64/debug-reftest-e10s-1 R1
   176 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-8 bc8
   169 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-6 bc6
   167 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
   162 - test-linux64/debug-mochitest-fis-e10s-1 1
   161 - test-linux64/debug-mochitest-sw-e10s-1 1
   161 - test-linux64/debug-mochitest-e10s-1 1
   158 - test-linux64/debug-reftest-e10s-7 R7
   158 - test-linux64/debug-reftest-no-accel-sw-e10s-7 Ru7
   158 - test-linux64/debug-reftest-sw-e10s-7 R7
   158 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
   155 - test-linux64/debug-reftest-e10s-5 R5
   155 - test-linux64/debug-reftest-sw-e10s-5 R5
   155 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
   155 - test-linux64/debug-reftest-no-accel-sw-e10s-5 Ru5
   149 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-6 bc6
   146 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
   146 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-4 Wr4
   138 - test-linux64/debug-mochitest-e10s-6 6
   138 - test-linux64/debug-mochitest-sw-e10s-6 6
   137 - test-linux64/debug-reftest-no-accel-sw-e10s-4 Ru4
   137 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
   137 - test-linux64/debug-reftest-sw-e10s-4 R4
   137 - test-linux64/debug-reftest-e10s-4 R4
   131 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-11 bc11
   130 - test-linux64/debug-reftest-e10s-6 R6
   130 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
   130 - test-linux64/debug-reftest-no-accel-sw-e10s-6 Ru6
   130 - test-linux64/debug-reftest-sw-e10s-6 R6
   126 - test-linux64/debug-mochitest-fis-e10s-4 4
   124 - test-linux64/debug-mochitest-sw-e10s-4 4
   124 - test-linux64/debug-mochitest-e10s-4 4
   122 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
   121 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-1 bc1
   119 - test-linux64/debug-reftest-no-accel-sw-e10s-3 Ru3
   119 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
   119 - test-linux64/debug-reftest-sw-e10s-3 R3
   119 - test-linux64/debug-reftest-e10s-3 R3
   119 - test-linux64/debug-mochitest-fis-e10s-6 6
   119 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-13 bc13
   116 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-7 bc7
   115 - test-linux64/debug-mochitest-e10s-3 3
   115 - test-linux64/debug-mochitest-sw-e10s-3 3
   114 - test-linux64/debug-mochitest-fis-e10s-3 3
   109 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
   105 - test-linux64/debug-mochitest-e10s-11 11
   105 - test-linux64/debug-mochitest-sw-e10s-11 11
    99 - test-linux64/debug-mochitest-fis-e10s-11 11
    98 - test-linux64/debug-mochitest-e10s-16 16
    98 - test-linux64/debug-mochitest-sw-e10s-16 16
    96 - test-linux64/debug-mochitest-fis-e10s-16 16
    93 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
    88 - test-linux64/debug-mochitest-media-fis-e10s-3 mda3
    88 - test-linux64/debug-mochitest-media-sw-e10s-3 mda3
    88 - test-linux64/debug-mochitest-media-e10s-3 mda3
    87 - test-linux64/debug-mochitest-media-spi-e10s-3 mda3
    81 - test-linux64/debug-mochitest-a11y-sw-1proc a11y
    81 - test-linux64/debug-mochitest-a11y-1proc a11y
    72 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-10 bc10
    38 - test-linux64/debug-mochitest-gpu-sw-e10s gpu
    38 - test-linux64/debug-mochitest-gpu-e10s gpu
    29 - test-linux64/debug-telemetry-tests-client-e10s c
    10 - test-linux64/debug-marionette-media-e10s MnM
     5 - test-linux64/debug-mochitest-remote-e10s remote
     5 - test-linux64/debug-mochitest-remote-sw-e10s remote
     2 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US

It shows up in 12541 tests. A few of the most prevalent:

  2678 - [e10s] Shutdown
  2090 -        Shutdown
  1641 - [e10s] layout/base/tests/test_reftests_with_caret.html
  1578 - [e10s] /html/browsers/origin/cross-origin-objects/cross-origin-objects.html
   840 - [e10s] /html/rendering/pixel-length-attributes.html
   720 - [e10s] dom/tests/mochitest/ajax/jquery/test_jQuery.html
   624 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-item-intrinsic-size-normal-002.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-item-intrinsic-size-normal-002-ref.html
   544 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/splitText-normalize.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/splitText-normalize-ref.html
   512 - [e10s] toolkit/components/antitracking/test/browser/browser_blockingMessaging.js
   436 - [e10s] /dom/nodes/Document-characterSet-normalization.html

[1] https://hg.mozilla.org/mozilla-central/annotate/e3a4bd8e4991ca6d26115faf528416e405759946/dom/ipc/nsQueryActor.h#l20

Agi, looks like you recently added this warning, can you take a look?

Flags: needinfo?(agi)
Regressed by: 1570115
Keywords: regression

Ah, I totally meant to remove that warning. Sorry about that, I'll send a patch soon.

Flags: needinfo?(agi)
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c21d1d12882 Remove unneded warning in do_QueryActor. r=kmag
Assignee: nobody → agi

https://hg.mozilla.org/mozilla-central/rev/3c21d1d12882

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: