Closed
Bug 1583457
Opened 5 years ago
Closed 5 years ago
ConsoleProgressListener is never used/tested with MONITOR_LOCATION_CHANGE
Categories
(DevTools :: Console, task, P3)
DevTools
Console
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
While reviewing mentions of window.top
in scope of Bug 1583444, I spotted the following comment:
/**
* Check if the current window.top location is changing, given the arguments
* of nsIWebProgressListener.onStateChange. If that is the case, the remote
* Web Console instance is notified.
* @private
*/
_checkLocationChange: function(progress, request, state) {
[...]
}
But the method itself is not using window.top at any point.
This was introduced a very long time ago: https://bugzilla.mozilla.org/show_bug.cgi?id=673148
It is only used if you call ConsoleProgressListener::startMonitor(2)
(2 is the value of ConsoleProgressListener.MONITOR_LOCATION_CHANGE
), but:
- coverage data shows the function is untested
- searchfox for
startMonitor(
leads to only one callsite: https://searchfox.org/mozilla-central/rev/153feabebc2d13bb4c29ef8adf104ec1ebd246ae/devtools/server/actors/webconsole.js#782-784 which doesn't use MONITOR_LOCATION_CHANGE, but MONITOR_FILE_ACTIVITY
I think we should remove this unused codepath
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2769fdb65549
Remove unused MONITOR_LOCATION_CHANGE option from ConsoleProgress r=nchevobbe
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in
before you can comment on or make changes to this bug.
Description
•