Closed Bug 1583934 Opened 5 years ago Closed 5 years ago

Port Bug 1573211 - Update Thunderbird CI to Clang 9.0.0

Categories

(Thunderbird :: Build Config, task)

Product:
Thunderbird
Component:
Build Config
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 71.0

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(3 files)

tb-clang9.patch
(deleted), patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
1583934-static-hwndForDOMWindow.patch
(deleted), patch
Details | Diff | Splinter Review
1583934-backout.patch
(deleted), patch
Details | Diff | Splinter Review

Firefox is moving to Clang 9. Clang 8 will no longer be available.

Attached patch tb-clang9.patch (deleted) — — Splinter Review
Upstream is currently on mozilla-incoming. I don't expect bustage, unless we run into some incompatibility with Thunderbird code and Clang 9. Using this as an opportunity to clean up a bit as well. Try job at: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=5746378e0b1ae6d4463a40e3b27a62c4e52f48fa
Attachment #9095267 - Flags: review?(geoff)
Assignee: nobody → rob
Status: NEW → ASSIGNED

Did you look at the try? Windows didn't compile at all :-(

Flags: needinfo?(rob)

I think your change is cool, but if this really uses clang-cl, than there seems to be a link problem:

[task 2019-09-25T20:37:35.910Z] 20:37:35 INFO - lld-link: warning: ignoring unknown argument '-RELEASE'
[task 2019-09-25T20:37:35.910Z] 20:37:35 INFO - lld-link: error: duplicate symbol: struct HWND__* __cdecl hwndForDOMWindow(class mozIDOMWindowProxy *) in ......\comm\mailnews\base\src\nsMessengerWinIntegration.obj and in ....\components\remote\nsWinRemoteServer.obj
[task 2019-09-25T20:37:35.911Z] 20:37:35 INFO - z:/build/build/src/config/rules.mk:657: recipe for target 'xul.dll' failed
[task 2019-09-25T20:37:35.911Z] 20:37:35 INFO - mozmake.EXE[4]: *** [xul.dll] Error 1

This
https://searchfox.org/comm-central/rev/f9b94449f75d2e465c1a25a7b01f8ba69c3f04ab/mozilla/toolkit/components/remote/nsWinRemoteServer.cpp#24-40
should probably be removed.

Flags: needinfo?(rob)

You want this ;-)

From the lld release notes at https://releases.llvm.org/9.0.0/tools/lld/docs/ReleaseNotes.html

lld-link now correctly reports duplicate symbol errors for object files that were compiled with /Gy. (r352590)

/Gy Put each function in its own section

Comment on attachment 9095267 [details] [diff] [review] tb-clang9.patch This is good. I've been in there myself: https://hg.mozilla.org/comm-central/log/tip/taskcluster/ci/toolchain/kind.yml
Attachment #9095267 - Flags: review?(geoff) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a34f8a48dc9e
Port bug 1573211: Update to clang 9.0.0. r=jorgk
https://hg.mozilla.org/comm-central/rev/2f32a40f4ea3
Make HWND hwndForDOMWindow() static so it doesn't clash with the M-C version. r=me

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
Attached patch 1583934-backout.patch (deleted) — — Splinter Review

Geoff, bug 1573211 is being backed out. We don't need to revert everything, just 9-->8 will do.

You may want to land this in 6 hours or so.

Flags: needinfo?(geoff)
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/0e193af944eb Revert to clang 8 since bug 1573211 was backed out. r=me
Flags: needinfo?(geoff)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: