layout.css.xul-box-display-values.survive-blockification.enabled breaks CFR panels
Categories
(Firefox :: Messaging System, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | unaffected |
| firefox69 | --- | unaffected |
| firefox70 | --- | unaffected |
| firefox71 | --- | verified |
People
(Reporter: asa, Assigned: andreio)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
image.png
Since enabling layout.css.xul-box-display-values.survive-blockification.enabled CFR panels are kind of a mess.
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
It also breaks my vertical tabs (via the "Tab Center Redux" addon), adding a black bar just right of the collapsed tabs.
On hover, the whole viewpoint shrinks, moving over content.
After disabling that flag behavior is back to normal and the vertical tab bar expands by overlaying the viewport.
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Comment 3•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 5•5 years ago
|
||
FYI: I believe this bug means that these panels aren't tested in automation, since before Bug 1582530 landed there were try pushes that would have crashed had it hit this case.
|
|
||
Comment 6•5 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #5)
FYI: I believe this bug means that these panels aren't tested in automation, since before Bug 1582530 landed there were try pushes that would have crashed had it hit this case.
Those try pushes didn’t include asserts for the display: flex cases, since a lot of the CSS that was caught by that display:flex assert didn’t require any change after unblockification from manual testing.
We can potentially revisit this by re-applying the assert, fixing all the cases one-by-one, removing the assert and then unapplying the “fixes” that make no differences.
|
|
||
Comment 7•5 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #6)
(In reply to Brian Grinstead [:bgrins] from comment #5)
FYI: I believe this bug means that these panels aren't tested in automation, since before Bug 1582530 landed there were try pushes that would have crashed had it hit this case.
Those try pushes didn’t include asserts for the display: flex cases, since a lot of the CSS that was caught by that display:flex didn’t require any change after unblockification from manual testing.
We can potentially revisit this by re-applying the assert, fixing all the cases one-by-one, removing the assert and then unapplying the “fixes” that make no differences.
Thanks for the clarification - nevermind then.
|
||
Updated•5 years ago
|
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
|
||
Comment 10•5 years ago
|
||
I have verified this issue on Firefox Beta 71.0 (Build ID:20191125204040) and Latest Firefox Nightly 72.0a1 (Build ID: 20191128094109) on Windows 10 x64, Mac 10.14.6 and Arch Linux 3.34.1.
All elements from the CFR panels are correctly displayed.
Description
•