Closed Bug 1584973 Opened 5 years ago Closed 5 years ago

Only load object inspector reducer file, not the whole bundle

Categories

(DevTools :: Inspector, task, P2)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(2 files)

We load the entire bundle only to use the objectInspector reducer in devtools/client/inspector/reducers.js#24-28.
We should try to only load the reducer file instead.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

This patch exposes the objectInspector reducer as a regular
file that can be required in the devtools codebase.
This should make things faster to start as we won't need
to load the entire bundle (especially for the inspector where
the reps is only used when navigating to specific subpanels).
This means we need to remove the flow typing for now since
we don't have a cross-toolbox build process like we have
in the debugger.

Depends on D47728

If you want a simpler inspector-only fix which allows you to keep flow typing, the following patch worked fine for the inspector metrics tests: https://hg.mozilla.org/try/rev/53f3108af87869c2588843693f439d1af55d6eb3

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e63ea229519d Expose object inspector's reducer file. r=jlast. https://hg.mozilla.org/integration/autoland/rev/c06273b25769 Always lazy load Reps bundle. r=Honza.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3bb37c5f2ba8 Expose object inspector's reducer file. r=jlast. https://hg.mozilla.org/integration/autoland/rev/df5e4d89de17 Always lazy load Reps bundle. r=Honza.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: