Closed
Bug 1585078
Opened 5 years ago
Closed 5 years ago
Audit usage of nsIDocShellTreeItem in GetRootWindow
Categories
(Core :: DOM: Navigation, defect, P2)
Core
DOM: Navigation
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: djvj, Assigned: tetsuharu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [rm-docshell-tree-item:hard])
Attachments
(2 files, 1 obsolete file)
Check users of this method, because it cannot survive as is. All users need to be fixed to use alternative mechanisms that don't involve directly manipulating the root window.
|
||
Updated•5 years ago
|
Fission Milestone: --- → M5
Priority: -- → P2
|
Reporter | |
Updated•5 years ago
|
Whiteboard: [rm-docshell-tree-item:hard]
|
|
||
Updated•5 years ago
|
Fission Milestone: M5 → Future
|
||
Comment 1•5 years ago
|
||
Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).
Fission Milestone: Future → M6
|
|
||
Updated•5 years ago
|
Summary: Fix usage of nsIDocShellTreeItem in GetRootWindow → Audit usage of nsIDocShellTreeItem in GetRootWindow
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
I seem we should refactor dom::Document::RequestFullscreen into separate paths for content process and no-conent process before tackling to remove GetRootWindow from Document.cpp
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
||
Updated•5 years ago
|
Attachment #9142374 -
Attachment is obsolete: true
|
|
||
Updated•5 years ago
|
Attachment #9142402 -
Attachment description: Bug 1585078 - part 2: Replace `GetRootWindow()` in Document.cpp with BrowsingContext. → Bug 1585078 - part 2: Remove calling `GetRootWindow()` from the the parent process.
|
|
||
Updated•5 years ago
|
Attachment #9142402 -
Attachment description: Bug 1585078 - part 2: Remove calling `GetRootWindow()` from the the parent process. → Bug 1585078 - part 2: Remove calling `GetRootWindow()` from the the child process.
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5657eec0de4c
part 1: Divide `Document::RequestFullScreen()` into seperate path to clarify the case in content process. r=nika
https://hg.mozilla.org/integration/autoland/rev/71cb60d53ecd
part 2: Remove calling `GetRootWindow()` from the the child process. r=nika
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5657eec0de4c
https://hg.mozilla.org/mozilla-central/rev/71cb60d53ecd
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•