Closed
Bug 1585187
Opened 5 years ago
Closed 5 years ago
Implement missing context menu in emailWizard.xul
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 71.0
People
(Reporter: aleca, Assigned: aleca)
References
(Regression)
Details
(Keywords: regression, ux-efficiency)
Attachments
(1 file)
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
The html:input fields in the new Email Account Wizard don't have a context menu.
Also, there are some leftover references to the "textbox" element in the emailWizard.js file.
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #9097529 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•5 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9097529 [details] [diff] [review]
1585187-emailwizard.patch
Review of attachment 9097529 [details] [diff] [review]:
-----------------------------------------------------------------
::: mail/components/accountcreation/content/emailWizard.js
@@ +127,5 @@
> function setText(id, value) {
> var element = e(id);
> assert(element, "setText() on non-existant element ID");
>
> + if (element.localName == "input" || element.localName == "label") {
Well... that's unexpected. Seems like a misuse of this function. But then again, the whole function is pointless.
Attachment #9097529 -
Flags: review?(mkmelin+mozilla) → review+
|
||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/387fad8b2d9c
Implement missing context menu in emailWizard.xul. r=mkmelin
|
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 71.0
You need to log in
before you can comment on or make changes to this bug.
Description
•