Closed Bug 1585364 Opened 5 years ago Closed 5 years ago

IsFrame check isn't working for fission

Categories

(Core :: DOM: Security, defect, P2)

Product:
Core
Component:
DOM: Security
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Project Flags:
Fission Milestone M4
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: jkt, Assigned: jkt)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

Bug 1585364 - Fix IsFrame check to work in fission.
(deleted), text/x-phabricator-request
Details

https://searchfox.org/mozilla-central/rev/23f836a71cfe961373c8bd0d0219ec60a64b3c8f/dom/base/nsFrameLoader.cpp#2133-2138 doesn't work post fission and so our cross origin iframes are considered as documents which will break most of our security checks.

It actually seems like this happens before the fission splits the process, however I think we should make the change as it makes it easier to reason about.

Whiteboard: [domsecurity-active]
Fission Milestone: --- → M5
Priority: P1 → P2
Fission Milestone: M5 → M4
Pushed by jkingston@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f3804bb2592c Fix IsFrame check to work in fission. r=ckerschb,nika

https://hg.mozilla.org/mozilla-central/rev/f3804bb2592c

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: