STR (with megabar enabled):

• Focus the megabar in any way (like Ctrl + L on Linux).
• Pres the Esc key. This selects the URL.
• Start typing to navigate somewhere else.

Expected:

• The results popup appears.

Actual:

• You can type on the URL bar, but there's no autocompletion or history of any sort.

Harry or Dão, could this be a regression caused specifically by bug 1583855?

This regression appears to be related to autofill behaviour. If the character typed after pressing ESC does not have an autofill result associated with it (e.g. typing a number or a special character) the view opens. Furthermore, this behaviour seems to have been introduced since bug 1583855 landed since this behaviour doesn't exist after reverting to the bug 1583855 patch. Can I please get a regressionwindow on this?

(In reply to Mike de Boer [:mikedeboer] from comment #1)

Harry or Dão, could this be a regression caused specifically by bug 1583855?

I would expect so. I suspect we're getting the results without displaying them because the height of the textbox is fixed.

Bug 1586052 might also be related. I think the root cause of both bugs is that there's an issue with the Focused & Collapsed state and the view opening. I'll investigate.

(In reply to Dão Gottwald [::dao] from comment #4)

(In reply to Mike de Boer [:mikedeboer] from comment #1)

Harry or Dão, could this be a regression caused specifically by bug 1583855?

I would expect so. I suspect we're getting the results without displaying them because the height of the textbox is fixed.

Bug 1586232 being fixed should make this more visible as we're not hiding content overflowing the textbox anymore.

STR:

1. Focus the urlbar and press "m" key (autocompletes to mozilla.org).
2. Press Esc key twice (removes results and shrinks megabar).
3. Press "m" key.

Results fail to appear, megabar does not expand.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5d83a502d367de1332ceb234275416f315328340&tochange=a633169505d41ea1377124758adc13eac7ec0ff0

Regressed by Bug 1584270.

Bug 1586232 improved the situation, now the results appear but still without megabar expansion.

https://hg.mozilla.org/mozilla-central/rev/9323e7d49d49