Fix direction of children-pointer in RTL
Categories
(DevTools :: Memory, defect, P3)
Tracking
(firefox-esr60 wontfix, firefox-esr68 wontfix, firefox67 wontfix, firefox68 wontfix, firefox69 wontfix, firefox70 wontfix, firefox71 verified)
People
(Reporter: itiel_yn8, Assigned: itiel_yn8)
References
(Blocks 2 open bugs, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
+++ This bug was initially created as a clone of Bug #1253327 +++
This was apparently fixed in bug 1253327, but for some reason this is still an issue.
Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7ef1e9abd296a8edc39b7efc8d637767ba2f77ed&tochange=1bc2ad020aee2830e0a7941f10958dbec108c254
Comment 2•5 years ago
|
||
:itiel_yn8, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.
Comment 3•5 years ago
|
||
Thanks for the report!
I investigated a bit, and I think the problem is that the transform isn't applied because the element is not a block element.
It's possible that bug 1485363 broke it, but it's not part of the regression window you found, so maybe another thing broke it before.
I think that adding display: inline-block
on .children-pointer
could work. Do you think you can try this?
Comment 4•5 years ago
|
||
Ah, from the regression window, I now think this is regressed by bug 1342672: it removes the "flex" layout. Indeed the flex layout forces a block element for the children, so removing it made it back to inline
which is its default.
Updated•5 years ago
|
(In reply to Julien Wajsberg [:julienw] from comment #3)
Thanks for the report!
I investigated a bit, and I think the problem is that the transform isn't applied because the element is not a block element.
It's possible that bug 1485363 broke it, but it's not part of the regression window you found, so maybe another thing broke it before.I think that adding
display: inline-block
on.children-pointer
could work. Do you think you can try this?
Thanks for looking into this.
This does work, but also re-introduces the issue mentioned in bug 1253327 comment 10.
To fix it, I changed this:
https://searchfox.org/mozilla-central/rev/deaf58acd27bc663750548e303ac2b461a821cf8/devtools/client/themes/memory.css#408
to padding-right
.
This feels kinda hacky, but I don't have a better idea. WDYT?
If that's okay with you I'd like to submit a patch.
Comment 6•5 years ago
|
||
Thanks for trying!
I think that's OK to use padding-right in this situation, but please also write a comment nearby explaining why it's OK (that because we use a transform to reverse the icon in RTL, the padding-right
gets properly reversed too).
Comment 9•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Updated•5 years ago
|
Updated•3 years ago
|
Description
•