Closed Bug 1585902 Opened 5 years ago Closed 5 years ago

Type `paused` event via protocol.js specification and use emit() instead of sendActorEvent

Categories

(DevTools :: Debugger, task, P3)

Product:
DevTools
Component:
Debugger
Type:
task

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: ochameau, Assigned: loganfsmyth)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Bug 1585902 - Use the protocoljs framework for emitting events. r=ochameau
(deleted), text/x-phabricator-request
Details

The thread actor is still using old API, pre-protcotol.js to emit a few of its events: sendActorEvent:
https://searchfox.org/mozilla-central/search?q=sendActorEvent(&case=true&regexp=false&path=thread.js

Doing this:

  • prevents easily passing actor instances in the payload of these events
  • make the thread actor special compare to all other one

Instead it should be using emit and type each attribute of the event in the thread specification:
https://searchfox.org/mozilla-central/source/devtools/shared/specs/thread.js#27-35
It looks like the specification has already been covered when implementing ThreadFront,
so it should be mostly about replacing sendActorEvent by emit.

Type: enhancement → task
Assignee: nobody → loganfsmyth
Status: NEW → ASSIGNED
Pushed by loganfsmyth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c7777eb19c6e
Use the protocoljs framework for emitting events. r=ochameau

https://hg.mozilla.org/mozilla-central/rev/c7777eb19c6e

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: