Closed
Bug 1585923
Opened 5 years ago
Closed 5 years ago
Rename MenuButton "doc" prop to "toolboxDoc"
Categories
(DevTools :: General, task, P3)
DevTools
General
Tracking
(firefox72 fixed)
RESOLVED
FIXED
Firefox 72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: jdescottes, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
See review comment at https://phabricator.services.mozilla.com/D47979#inline-292133
Passing another document than the toolbox document to a MenuButton will confuse the HTMLTooltip.
We should make this clearer by renaming the property.
|
Reporter | |
Comment 1•5 years ago
|
||
The property mentioned in the summary:
https://searchfox.org/mozilla-central/rev/35cc00a25c4471993fdaa5761952bd3afd4f1731/devtools/client/shared/components/menu/MenuButton.js#46
Call sites to update: https://searchfox.org/mozilla-central/search?q=+MenuButton%28&path=devtools
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•5 years ago
|
||
This should make it more obvious what kind of document
the component is expecting.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa97283e9f5d
Rename MenuButton doc prop to toolboxDoc. r=jdescottes.
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•